From owner-freebsd-ports@FreeBSD.ORG Sat Jun 16 14:53:44 2012 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4118F106564A; Sat, 16 Jun 2012 14:53:44 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 229518FC08; Sat, 16 Jun 2012 14:53:44 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5GEriKA040672; Sat, 16 Jun 2012 14:53:44 GMT (envelope-from bapt@FreeBSD.org) Received: (from bapt@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5GErhrl040671; Sat, 16 Jun 2012 14:53:43 GMT (envelope-from bapt@FreeBSD.org) X-Authentication-Warning: freefall.freebsd.org: bapt set sender to bapt@FreeBSD.org using -f Date: Sat, 16 Jun 2012 16:53:41 +0200 From: Baptiste Daroussin To: Matthew Seaman Message-ID: <20120616145341.GK98264@ithaqua.etoilebsd.net> References: <4FD8AFEC.6070605@FreeBSD.org> <4FDC9488.2010509@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nzri8VXeXB/g5ayr" Content-Disposition: inline In-Reply-To: <4FDC9488.2010509@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Chris Rees , freebsd-ports Subject: Re: [CFT] UNIQUENAME patches X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2012 14:53:44 -0000 --nzri8VXeXB/g5ayr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 16, 2012 at 03:13:28PM +0100, Matthew Seaman wrote: > On 16/06/2012 14:18, Chris Rees wrote: > > That's great-- though rather than patching colliding-only ports, can't > > we just add the category to it? > >=20 > > .for cat in ${CATEGORIES} > > UNIQUEPREFIX?=3D ${cat} > > .endfor > >=20 > > (copying the code from PKGCATEGORY; might be better off moving the > > PKGCATEGORY code up higher and just using that). >=20 > Yes. I thought long and hard about doing that, but I opted not to for > two reasons: >=20 > 1) Using the port name + a uniqueprefix where necessary produces what > is close to the minimal change required to give every port a > unique name. The UNIQUENAME won't actually change for quite a > lot of ports under my scheme. >=20 > 2) As a way of future-proofing against reorganizations of the ports > tree. What tends to happen is that a new category is invented > and a number of ports are moved into it. My way should avoid > changing the UNIQUENAME in the majority of cases. >=20 > Remember that changing the UNIQUENAME changes where the record of the > port options are stored, and either we annoy a lot of users by making > them fill in a buch of dialogues all over again, or we have to invent > some complicated mechanism copy the old options settings to the new > directory. (Yes -- this sort of thing will occur with the changes as > written. It can't be avoided entirely.) >=20 > Plus I think it would be more natural and easier for maintainers and > end-users to talk about (say) "phpmyadmin" rather than > "databases-phpmyadmin." >=20 > Cheers, >=20 > Matthew >=20 > --=20 > Dr Matthew J Seaman MA, D.Phil. > PGP: http://www.infracaninophile.co.uk/pgpkey >=20 >=20 >=20 >=20 I'm strongly against adding something related to the category automatically. Because I'm thinking about binary managerment, adding PKGCATEGORY to unique= name would mean a package tracking will be lots in case of moving a port from a category to another. Currently in pkgng a package is identified by its orig= in and thus can't survive automatically from a move, because origin changes. Having a uniquename able to survive from move can help a lot avoiding compl= ex detection of move and keeping tracking easily the package. What could be added is a UNIQUENAMESUFFIX to be able to have a finer grain = name. regards, Bapt --nzri8VXeXB/g5ayr Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAk/cnfUACgkQ8kTtMUmk6EzFCACfQBZ8swU6enG398wLxj1MylTO dbcAn0kwDPTjPZ+gWQIs2b2Kme1VcxSy =GmKs -----END PGP SIGNATURE----- --nzri8VXeXB/g5ayr--