From owner-freebsd-bugs@FreeBSD.ORG Thu Sep 22 16:15:29 2011 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4FA9106564A; Thu, 22 Sep 2011 16:15:29 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com [209.85.216.175]) by mx1.freebsd.org (Postfix) with ESMTP id 4DBCE8FC08; Thu, 22 Sep 2011 16:15:29 +0000 (UTC) Received: by qyk10 with SMTP id 10so6311876qyk.13 for ; Thu, 22 Sep 2011 09:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=b4sfLQOMH3opg4C80ffkOoh+eJIPcW8RDQ/2g80g7CM=; b=Ys507iAwa6qdEYVlYpvEYYDoVTmszzYgrCKh1ndKi7OBLzF0CqLyYl6+nHRJOCNRIj FxyHfYuqkAGyULjMDqW1+pFdRGQrgdNG085/9edH09ubikkXWJxXxZbdc1SY5iM0EZ0x iiOgIlE48huLflXgz2EEv3xjS97tIS00WUqDo= MIME-Version: 1.0 Received: by 10.224.217.137 with SMTP id hm9mr1931752qab.124.1316706796321; Thu, 22 Sep 2011 08:53:16 -0700 (PDT) Received: by 10.224.74.82 with HTTP; Thu, 22 Sep 2011 08:53:16 -0700 (PDT) In-Reply-To: <25F8136F-8476-4746-91A9-EAADA3C8D20F@bsdimp.com> References: <201109220755.p8M7t0Vx081424@freefall.freebsd.org> <25F8136F-8476-4746-91A9-EAADA3C8D20F@bsdimp.com> Date: Thu, 22 Sep 2011 08:53:16 -0700 Message-ID: From: Garrett Cooper To: Warner Losh Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-bugs@freebsd.org, Warner Losh , linimon@freebsd.org Subject: Re: conf/160896: [nanobsd] [patch] use getopts, jobs option, delay -c usage improvements to nanobsd.sh X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2011 16:15:29 -0000 On Thu, Sep 22, 2011 at 1:57 AM, Warner Losh wrote: > Rejecting parts of this patch. =A0Specifically, the delated -c stuff is b= ogusly implemented. =A0Before the change, you could have multiple -c option= s on the command line. =A0after this you can't. I'm wouldn't mind doing something like this: nano_confs while getopts '...' optch do case "$optch" in ... c) nano_confs=3D"$nano_confs $OPTARG" ;; ... for nano_conf in $nano_confs; do . $nano_confs done The problem I was trying to work around is that (unfortunately) some packages code features (ipv6) into the names (take apr for instance), which means that the logic in FreeNAS currently always says "build a fat image" when $DEBUG =3D=3D 1. > Don't like how -j is implemented in this patch. =A0Need to think about th= is because it breaks some nanobsd config files that specify NANO_PMAKE comm= and. My concern was that not all of my build machines are homogeneous. I have access to some "powerhouse" server machines and some low power desktops. FreeNAS had -j8 coded into NANO_PMAKE, but I made it variable ($CPUS), but I thought that was a bad idea for what should go back into nanobsd (it didn't match the defaults and could cause other issues) -- if the default (1) is incorrect, I'm all for bumping it up to 3 again. I just wasn't sure why 3 was the chosen default. > Other stuff looks good and it, or variations of it, will go in when we're= out of the freeze. Thanks for the feedback! -Garrett