From owner-svn-src-all@FreeBSD.ORG Wed Sep 1 21:31:19 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 68E2F10656AD; Wed, 1 Sep 2010 21:31:19 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 2DA3F8FC0C; Wed, 1 Sep 2010 21:31:19 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id B1B9B46B35; Wed, 1 Sep 2010 17:31:18 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id DD8588A03C; Wed, 1 Sep 2010 17:31:17 -0400 (EDT) From: John Baldwin To: Matthew D Fleming Date: Wed, 1 Sep 2010 17:31:12 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <201009012032.o81KWmu5080032@svn.freebsd.org> In-Reply-To: <201009012032.o81KWmu5080032@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201009011731.12499.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Wed, 01 Sep 2010 17:31:17 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212115 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Sep 2010 21:31:19 -0000 On Wednesday, September 01, 2010 4:32:48 pm Matthew D Fleming wrote: > Author: mdf > Date: Wed Sep 1 20:32:47 2010 > New Revision: 212115 > URL: http://svn.freebsd.org/changeset/base/212115 > > Log: > Fix a bug with sched_affinity() where it checks td_pinned of another > thread in a racy manner, which can lead to attempting to migrate a > thread that is pinned to a CPU. Instead, have sched_switch() determine > which CPU a thread should run on if the current one is not allowed. > > KASSERT in sched_bind() that the thread is not yet pinned to a CPU. > > KASSERT in sched_switch() that only migratable threads or those moving > due to a sched_bind() are changing CPUs. > > sched_affinity code came from jhb@. > > MFC after: 2 weeks Cool, I guess this fixed it in your tests then? -- John Baldwin