From owner-freebsd-current Tue Mar 14 15:06:14 1995 Return-Path: current-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id PAA11901 for current-outgoing; Tue, 14 Mar 1995 15:06:14 -0800 Received: from cs.weber.edu (cs.weber.edu [137.190.16.16]) by freefall.cdrom.com (8.6.10/8.6.6) with SMTP id PAA11894 for ; Tue, 14 Mar 1995 15:06:09 -0800 Received: by cs.weber.edu (4.1/SMI-4.1.1) id AA09748; Tue, 14 Mar 95 15:59:58 MST From: terry@cs.weber.edu (Terry Lambert) Message-Id: <9503142259.AA09748@cs.weber.edu> Subject: Re: MINFREE change to 8% To: roberto@blaise.ibp.fr (Ollivier Robert) Date: Tue, 14 Mar 95 15:59:58 MST Cc: current@FreeBSD.org In-Reply-To: <9503142158.AA08648@blaise.ibp.fr> from "Ollivier Robert" at Mar 14, 95 10:58:34 pm X-Mailer: ELM [version 2.4dev PL52] Sender: current-owner@FreeBSD.org Precedence: bulk > I've noticed with the change to MINFREE from 5% to 8% that there is > something strange in the ufs/ffs/ffs_alloc.c file : > > case FS_OPTSPACE: > /* > * Allocate an exact sized fragment. Although this makes > * best use of space, we will waste time relocating it if > * the file continues to grow. If the fragmentation is > * less than half of the minimum free reserve, we choose > * to begin optimizing for time. > */ > request = nsize; > if (fs->fs_minfree <= 5 || <<<<<<<< shouldn't 5 be MINFREE instead ?? MINFREE/2. The 5 is based on the historical default of 10%. This assumes MINFREE is a non-runtime adjustable manifest constant, right? The compare is a magic cookie to force space optimization even if the user has requested otherwise, since the user may run out of space very soon. Terry Lambert terry@cs.weber.edu --- Any opinions in this posting are my own and not those of my present or previous employers.