From owner-freebsd-mips@freebsd.org Sat Feb 10 19:50:34 2018 Return-Path: Delivered-To: freebsd-mips@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CCADEF18A11 for ; Sat, 10 Feb 2018 19:50:34 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 574056EEA7; Sat, 10 Feb 2018 19:50:34 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-wm0-x22c.google.com with SMTP id i186so3121506wmi.4; Sat, 10 Feb 2018 11:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=9XyhxY7LuZ2xCjcqbckYqgoE7KBaZL0IiqoQ3OBfs3k=; b=XUsFg+FZFIOS/baBCbS4S6bfJJBvtto3kkEgyc7lcu7gqjBoppHJ3yNgUmNSdTTfQq ifmgtMcsUhXltRwaThGOBDIX8D0h5uS/3iTA0SInSYQs3kc4emZod9RTALwi5paQXKeZ u/7h8riMGDAXqGm64ct9Gx+HGCRM19xgysoBQq4uXDtPUD4nCPh5xMjYKFZG3Gj1v08a q58pYOjL3a4ysn0MoD//fIUqrpUBdYCQc2BZ5ul3USpNbM2qKrVTrlkaVldvlGShCLp1 KWbhWCSsbe1Jk00fF1jRN3vK6bI4U6tl/dzSPh17YecZR0pSnqgu51VoYi4MVg/GvTdr 98pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=9XyhxY7LuZ2xCjcqbckYqgoE7KBaZL0IiqoQ3OBfs3k=; b=JLtSOQUOcxy1bGg1XEab6I02Jpg0YJaJwASVzgXTLDyXEO62EdLR5mtkZEEcFCIyzz GFLfZ0ykn1cRn7HSC/iKqaa5nIWX7SQBDY29T/asv3Yd61GG8mLfh25rmZCwgpxlHwlg 7hFKTTmqS/UwRxKKFEb8ISVGQIQYDvzCnL1DeQRSdNPWGvQ8iCMlMVnQ27lF2jJIOTFM JOcsJ32nsATr+NGRkTWpjmpmOucMN6RP/QZ7gYhWbrOvspzCx+WrdexoJxM3qLmF0G5V fC6loEFndN2cjlNJSHJvRC2w2qZXLMxDTHUn59Tq6imdI+wCR/PvmINkGgJfKVYaTJ0Q nAyw== X-Gm-Message-State: APf1xPAtSmpvcmtCwwigMDL10wglwnrP6+1HQajMCbgxKIMTkJ4gz8Oh jNeKJlpK1JJpp9RMPz1AS73JbBa1hgQXKFI70QzucQ== X-Google-Smtp-Source: AH8x2240pMX8IHfRzGfJI5kwtJemcDUlDUcYBBJf7VdDJ39YoNuWqoj321Mp6mV9Z/x802dLIWupCaWqOA/X4bb8lrA= X-Received: by 10.28.71.198 with SMTP id m67mr5510481wmi.40.1518292233191; Sat, 10 Feb 2018 11:50:33 -0800 (PST) MIME-Version: 1.0 Sender: adrian.chadd@gmail.com Received: by 10.28.131.8 with HTTP; Sat, 10 Feb 2018 11:50:32 -0800 (PST) In-Reply-To: <406460.12451.qm@web101716.mail.ssk.yahoo.co.jp> References: <87596.64393.qm@web101718.mail.ssk.yahoo.co.jp> <4510846.CbLV3ucMtE@ralph.baldwin.cx> <406460.12451.qm@web101716.mail.ssk.yahoo.co.jp> From: Adrian Chadd Date: Sat, 10 Feb 2018 11:50:32 -0800 X-Google-Sender-Auth: Ul-nCSJSvVXdL4Q_-pdFhTPMJGI Message-ID: Subject: Re: kld not work on Atheros To: Mori Hiroki Cc: John Baldwin , Michael Zhilin , "freebsd-mips@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Feb 2018 19:50:35 -0000 hi, Mori - did you try John's patch and it worked ok? -a On 8 February 2018 at 02:58, Mori Hiroki wrote: > Hi > > Sorry too late reply. > > I try to head code now. Work fine. Thanks. > > Hiroki Mori > > > ----- Original Message ----- >> From: John Baldwin >> To: Adrian Chadd >> Cc: Michael Zhilin ; Mori Hiroki ; "freebsd-mips@freebsd.org" >> Date: 2018/2/2, Fri 05:06 >> Subject: Re: kld not work on Atheros >> >> On Wednesday, January 31, 2018 02:12:42 PM Adrian Chadd wrote: >>> Hi, >>> >>> Bump - do I just put in an #ifdef MIPS around this workaround for now, >>> or what's the cleaner solution? :) >> >> Cleaner solution is to not load reltabs or relatabs for sections that don't >> have SHF_ALLOC set. That is, earlier in load_elf_obj.c (in loader) and >> in link_elf_obj.c when looping over SHT_RELTAB and SHT_RELTABA sections, >> ignore relocation tables whose associated section doesn't have SHF_ALLOC >> set. >> >> Try this (untested): >> >> diff --git a/stand/common/load_elf_obj.c b/stand/common/load_elf_obj.c >> index b58dde0dfbf8..4c893e17a5b1 100644 >> --- a/stand/common/load_elf_obj.c >> +++ b/stand/common/load_elf_obj.c >> @@ -282,6 +282,8 @@ __elfN(obj_loadimage)(struct preloaded_file *fp, elf_file_t >> ef, u_int64_t off) >> switch (shdr[i].sh_type) { >> case SHT_REL: >> case SHT_RELA: >> + if ((shdr[shdr[i].sh_info].sh_flags & SHF_ALLOC) == 0) >> + break; >> lastaddr = roundup(lastaddr, shdr[i].sh_addralign); >> shdr[i].sh_addr = (Elf_Addr)lastaddr; >> lastaddr += shdr[i].sh_size; >> diff --git a/sys/kern/link_elf_obj.c b/sys/kern/link_elf_obj.c >> index 448d5b9c08a5..0bcec40822e1 100644 >> --- a/sys/kern/link_elf_obj.c >> +++ b/sys/kern/link_elf_obj.c >> @@ -272,9 +272,17 @@ link_elf_link_preload(linker_class_t cls, const char >> *filename, >> symstrindex = shdr[i].sh_link; >> break; >> case SHT_REL: >> + /* >> + * Ignore relocation tables for sections not >> + * loaded by the loader. >> + */ >> + if (shdr[shdr[i].sh_info].sh_addr == 0) >> + break; >> ef->nreltab++; >> break; >> case SHT_RELA: >> + if (shdr[shdr[i].sh_info].sh_addr == 0) >> + break; >> ef->nrelatab++; >> break; >> } >> @@ -398,12 +406,16 @@ link_elf_link_preload(linker_class_t cls, const char >> *filename, >> pb++; >> break; >> case SHT_REL: >> + if (shdr[shdr[i].sh_info].sh_addr == 0) >> + break; >> ef->reltab[rl].rel = (Elf_Rel *)shdr[i].sh_addr; >> ef->reltab[rl].nrel = shdr[i].sh_size / sizeof(Elf_Rel); >> ef->reltab[rl].sec = shdr[i].sh_info; >> rl++; >> break; >> case SHT_RELA: >> + if (shdr[shdr[i].sh_info].sh_addr == 0) >> + break; >> ef->relatab[ra].rela = (Elf_Rela *)shdr[i].sh_addr; >> ef->relatab[ra].nrela = >> shdr[i].sh_size / sizeof(Elf_Rela); >> @@ -620,9 +632,17 @@ link_elf_load_file(linker_class_t cls, const char >> *filename, >> symstrindex = shdr[i].sh_link; >> break; >> case SHT_REL: >> + /* >> + * Ignore relocation tables for unallocated >> + * sections. >> + */ >> + if ((shdr[shdr[i].sh_info].sh_flags & SHF_ALLOC) == 0) >> + break; >> ef->nreltab++; >> break; >> case SHT_RELA: >> + if ((shdr[shdr[i].sh_info].sh_flags & SHF_ALLOC) == 0) >> + break; >> ef->nrelatab++; >> break; >> case SHT_STRTAB: >> @@ -880,6 +900,8 @@ link_elf_load_file(linker_class_t cls, const char *filename, >> pb++; >> break; >> case SHT_REL: >> + if ((shdr[shdr[i].sh_info].sh_flags & SHF_ALLOC) == 0) >> + break; >> ef->reltab[rl].rel = malloc(shdr[i].sh_size, M_LINKER, >> M_WAITOK); >> ef->reltab[rl].nrel = shdr[i].sh_size / sizeof(Elf_Rel); >> @@ -898,6 +920,8 @@ link_elf_load_file(linker_class_t cls, const char *filename, >> rl++; >> break; >> case SHT_RELA: >> + if ((shdr[shdr[i].sh_info].sh_flags & SHF_ALLOC) == 0) >> + break; >> ef->relatab[ra].rela = malloc(shdr[i].sh_size, M_LINKER, >> M_WAITOK); >> ef->relatab[ra].nrela = >> >> -- >> John Baldwin >>