Date: Fri, 11 Sep 2020 14:20:22 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: "Tomoaki AOKI" <junchoon@dec.sakura.ne.jp> Cc: freebsd-current@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r365419 - in head/sys/dev: ath bwi iwm iwn mwl otus usb/wlan wtap Message-ID: <CAF67749-349A-4B02-96E3-74BA66195A51@FreeBSD.org> In-Reply-To: <20200911230248.d520bf8a1f3397be5d0f26c3@dec.sakura.ne.jp> References: <20200910074135.45d5b208b083c93efbce9259@dec.sakura.ne.jp> <178A8155-90E0-4B3E-BBCB-D3C7CA4C62B2@FreeBSD.org> <20200911230248.d520bf8a1f3397be5d0f26c3@dec.sakura.ne.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11 Sep 2020, at 14:02, Tomoaki AOKI wrote: > On Thu, 10 Sep 2020 10:22:05 +0000 > "Bjoern A. Zeeb" <bz@FreeBSD.org> wrote: > >> On 9 Sep 2020, at 22:41, Tomoaki AOKI wrote: >> >>> This breaks at least iwm. (Other drivers not tested.) >>> >>> Messages below are repeatedly shown and no carrier detected. >>> Manually reverting this commit fixes the issue. >>> >>> iwm0: failed to send antennas before calibration: 35 >>> iwm_run_init_ucode: failed 35 >>> iwm_init_hw failed 35 >>> iwm0: could not initiate scan >>> >>> >>> and lesser times messages below. >>> >>> iwm0: iwm_send_phy_db_data: Cannot send HCMD of Phy DB cfg section, >>> 35 >>> iwm_init_hw failed 35 >>> iwm0: could not initiate scan >>> >> >> >> I’ll try to test iwm as well, in case you are faster, can you >> please >> try this instead of reverting; the previous version never made it >> past >> the first return anymore in the last years it seems, so we can remove >> the function entirely to keep the status quo: >> >> Sorry for the oversight. > > Your patch (needed to fix some line wrapping, though) fixed the issue > for me. Thanks! Committed in r365633 in HEAD. stable/12 already has the fix (#if 0ed the code). I’ll merged the change in 3 days to keep the code in sync. Thanks a lot for reporting and testing! Bjoern
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF67749-349A-4B02-96E3-74BA66195A51>