From owner-freebsd-current@FreeBSD.ORG Sun Dec 10 21:36:34 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 338C616A47C for ; Sun, 10 Dec 2006 21:36:34 +0000 (UTC) (envelope-from nick@van-laarhoven.org) Received: from smtp-3.orange.nl (smtp-3.orange.nl [193.252.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id 56F4F43CBF for ; Sun, 10 Dec 2006 21:35:09 +0000 (GMT) (envelope-from nick@van-laarhoven.org) Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf6212.orange.nl (SMTP Server) with ESMTP id EF09A1C00087 for ; Sun, 10 Dec 2006 22:36:19 +0100 (CET) Received: from uitsmijter.van-laarhoven.org (ap-zvhz-13f05.adsl.wanadoo.nl [81.69.93.5]) by mwinf6212.orange.nl (SMTP Server) with ESMTP id C5FDE1C00081 for ; Sun, 10 Dec 2006 22:36:19 +0100 (CET) X-ME-UUID: 20061210213619811.C5FDE1C00081@mwinf6212.orange.nl Received: (qmail 37896 invoked from network); 10 Dec 2006 21:36:19 -0000 Received: from 10.66.0.143 by uitsmijter.van-laarhoven.org (envelope-from , uid 82) with qmail-scanner-1.25 (clamdscan: 0.88.4/2187. f-prot: 4.6.6/3.16.14. spamassassin: 3.1.7. Clear:RC:1(10.66.0.143):. Processed in 0.398791 secs); 10 Dec 2006 21:36:19 -0000 X-Qmail-Scanner-Mail-From: nick@van-laarhoven.org via uitsmijter.van-laarhoven.org X-Qmail-Scanner: 1.25 (Clear:RC:1(10.66.0.143):. Processed in 0.398791 secs) Received: from unknown (HELO van-laarhoven.org) (nick@10.66.0.143) by uitsmijter.van-laarhoven.org with SMTP; 10 Dec 2006 21:36:18 -0000 Received: (nullmailer pid 1339 invoked by uid 1001); Sun, 10 Dec 2006 21:36:17 -0000 Date: Sun, 10 Dec 2006 22:36:17 +0100 (CET) From: Nick Hibma X-X-Sender: nick@localhost To: Marius Strobl In-Reply-To: <20061210152755.GA45265@alchemy.franken.de> Message-ID: <20061210223217.M1174@localhost> References: <20061210110419.H42195@localhost> <20061210152755.GA45265@alchemy.franken.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: FreeBSD CURRENT Mailing List Subject: Re: Slight interface change on the watchdog fido X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Dec 2006 21:36:34 -0000 > I recognise this as the previous watchdog function API with > the extension that when told to disarm via a timeout value > of 0 the watchdog may now report failure to do so by setting > *error, correct? True, see the changes on the manpage. > If so this is fine with the stock mk48txx.c. Yes, that was the one watchdog that followed the sample in the Elan specific code correctly. At first I didn't have the interface change in and that meant changing mk48txx.c and I missed that afterwards I changed everything back to what is was in that driver. > Regarding your changes to watchdog.4 and watchdog.9 AFAICT > they violate the established style guidelines for FreeBSD > man pages; the source should wrap the line on sentence breaks. Is there a manual for man page writing? I've not done much of that yet. Nick