From owner-freebsd-multimedia Mon Jul 14 03:40:29 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id DAA12986 for multimedia-outgoing; Mon, 14 Jul 1997 03:40:29 -0700 (PDT) Received: from labinfo.iet.unipi.it (labinfo.iet.unipi.it [131.114.9.5]) by hub.freebsd.org (8.8.5/8.8.5) with SMTP id DAA12975 for ; Mon, 14 Jul 1997 03:40:23 -0700 (PDT) Received: from localhost (luigi@localhost) by labinfo.iet.unipi.it (8.6.5/8.6.5) id LAA10468 for multimedia@freebsd.org; Mon, 14 Jul 1997 11:35:42 +0200 From: Luigi Rizzo Message-Id: <199707140935.LAA10468@labinfo.iet.unipi.it> Subject: guspnp9 - sb recording bug To: multimedia@freebsd.org Date: Mon, 14 Jul 1997 11:35:41 +0200 (MET DST) X-Mailer: ELM [version 2.4 PL23] Content-Type: text Sender: owner-multimedia@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > It is hard for me to read the differences between guspnp7 and guspnp9 given > that guspnp9 was run thru indent. Typically , this should be done > after all the changes have gone in and the driver was tested. I had no choice, my mind refuses to work on ugly-looking code :) In any case, one solution is to run the old code through indent and then try a "diff". If someone has problems recording with the sb (perhaps in 16-bit mode) note that in snd970711 (and then in guspnp9 ?) there was a typo in sb_dsp.c. In sb_dsp_start_input(), around line 404, you should apply the following fix if (sb_dsp_command(DSP_CMD_HSSIZE)) { /* High speed size */ sb_dsp_command((u_char) (dsp_count & 0xff)); sb_dsp_command((u_char) ((dsp_count >> 8) & 0xff)); - sb_dsp_command(DSP_CMD_HSDAC); /* High speed 8 bit ADC */ + sb_dsp_command(DSP_CMD_HSADC); /* High speed 8 bit ADC */ } else printf("SB Error: Unable to start (high speed) ADC\n"); splx(flags); } else { The correct definition in file sb_card.h should be: #define DSP_CMD_HSDAC 0x91 /* high speed dac */ #define DSP_CMD_HSADC 0x99 /* high speed adc */ Boy, I hope that's all by now. Thanks everybody for all the testing and feedback you have provided. Cheers Luigi -----------------------------+-------------------------------------- Luigi Rizzo | Dip. di Ingegneria dell'Informazione email: luigi@iet.unipi.it | Universita' di Pisa tel: +39-50-568533 | via Diotisalvi 2, 56126 PISA (Italy) fax: +39-50-568522 | http://www.iet.unipi.it/~luigi/ _____________________________|______________________________________