Date: Sun, 7 Apr 2002 16:58:27 -0700 From: Maxime Henrion <mux@freebsd.org> To: freebsd-net@FreeBSD.org Cc: Brooks Davis <brooks@one-eyed-alien.net> Subject: Re: review request: minor cloning API change Message-ID: <20020407235827.GE6519@elvis.mu.org> In-Reply-To: <20020405230719.A13516@Odin.AC.HMC.Edu> References: <20020405230719.A13516@Odin.AC.HMC.Edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Brooks Davis wrote: > The following patch reverts a previous API change which change the > return value of a clonable interfaces' destory function from void to > int to allow the interface to refuse to delete a unit. Since we now > manage unit creation in the generic cloning code and the only use mux or > I could thing of for refusing to delete a unit was forcing a certain > number of units to exist, I've added a new member to the cloner struct, > ifc_minifs which specifies the minimum number of units of this device > allowed. This changes the initilizer macro, but we already differ from > NetBSD in that area and we get to revert to function signatures that > match those from NetBSD in exchange. > > This diff also includes code to convert the disc interface to be > clonable and unloadable. This will be commited seperatly. This patch looks perfectly fine to me. Regarding Julian's mail, it would be straightforward to change the return type back to int if we ever need to (and I hope we won't), so I don't think this is really an issue. Maxime To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020407235827.GE6519>