From owner-freebsd-current@FreeBSD.ORG Wed Jul 14 09:26:27 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD9BB16A4CE for ; Wed, 14 Jul 2004 09:26:27 +0000 (GMT) Received: from smtp001.bizmail.yahoo.com (smtp001.bizmail.yahoo.com [216.136.172.125]) by mx1.FreeBSD.org (Postfix) with SMTP id 7D47B43D1D for ; Wed, 14 Jul 2004 09:26:27 +0000 (GMT) (envelope-from noackjr@alumni.rice.edu) Received: from unknown (HELO optimator.noacks.org) (noackjr@supercrime.org@70.240.179.251 with login) by smtp001.bizmail.yahoo.com with SMTP; 14 Jul 2004 09:26:27 -0000 Received: from localhost (localhost [127.0.0.1]) by optimator.noacks.org (Postfix) with ESMTP id 7ADCD6157; Wed, 14 Jul 2004 04:26:26 -0500 (CDT) Received: from optimator.noacks.org ([127.0.0.1]) by localhost (optimator.noacks.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 00585-01; Wed, 14 Jul 2004 04:26:24 -0500 (CDT) Received: from compgeek.noacks.org (compgeek [192.168.1.10]) by optimator.noacks.org (Postfix) with ESMTP id 8033A6101; Wed, 14 Jul 2004 04:26:24 -0500 (CDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by compgeek.noacks.org (8.12.11/8.12.11) with ESMTP id i6E9QNuO002935; Wed, 14 Jul 2004 04:26:23 -0500 (CDT) (envelope-from noackjr@alumni.rice.edu) Message-ID: <40F4FC3E.5000808@alumni.rice.edu> Date: Wed, 14 Jul 2004 04:26:22 -0500 From: Jon Noack User-Agent: Mozilla Thunderbird 0.7.1 (X11/20040629) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michael Nottebrock References: <26075.1089753893@critter.freebsd.dk> <20040713232214.GA9507@dhcp50.pn.xcllnt.net> <200407141056.44351.michaelnottebrock@gmx.net> In-Reply-To: <200407141056.44351.michaelnottebrock@gmx.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at noacks.org cc: freebsd-current@FreeBSD.org cc: Garance A Drosihn cc: Marcel Moolenaar Subject: Re: CVSUP and 5.2.1 RELEASE X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: noackjr@alumni.rice.edu List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2004 09:26:27 -0000 On 07/14/04 03:56, Michael Nottebrock wrote: > On Wednesday 14 July 2004 04:24, Garance A Drosihn wrote: >> At 4:22 PM -0700 7/13/04, Marcel Moolenaar wrote: >>> On Tue, Jul 13, 2004 at 06:23:38PM -0400, Garance A Drosihn wrote: >>>> a) how about if we print a warning and exit if DESTDIR is >>>> not defined? Are there "important" uses of `make world' >>>> which do not use DESTDIR? >>> >>> My thoughts exactly. See attached patch. >> >> Actually, the target should end with some kind of failure, in case >> someone has a script that does: >> make world && do-next-thing > > Why should make world DESTDIR=/my/jail && cd etc && make distribution > DESTDIR=/my/jail fail? It won't fail. If you read the patch and thread a bit more closely you'll note that the warning and failure happen only if DESTDIR is not defined. As you are defining DESTDIR, you won't see any change in behavior/output. Jon