From owner-freebsd-arch@FreeBSD.ORG Wed Nov 12 19:51:50 2014 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ED74B226; Wed, 12 Nov 2014 19:51:50 +0000 (UTC) Received: from dmz-mailsec-scanner-3.mit.edu (dmz-mailsec-scanner-3.mit.edu [18.9.25.14]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FF8EE8C; Wed, 12 Nov 2014 19:51:49 +0000 (UTC) X-AuditID: 1209190e-f79d46d000003643-12-5463ba4e9337 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) (using TLS with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP id 3F.B0.13891.E4AB3645; Wed, 12 Nov 2014 14:51:42 -0500 (EST) Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id sACJpflK009081; Wed, 12 Nov 2014 14:51:41 -0500 Received: from multics.mit.edu (system-low-sipb.mit.edu [18.187.2.37]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id sACJpdUr031128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 12 Nov 2014 14:51:40 -0500 Received: (from kaduk@localhost) by multics.mit.edu (8.12.9.20060308) id sACJpctC005479; Wed, 12 Nov 2014 14:51:38 -0500 (EST) Date: Wed, 12 Nov 2014 14:51:38 -0500 (EST) From: Benjamin Kaduk X-X-Sender: kaduk@multics.mit.edu To: Konstantin Belousov Subject: Re: Removal of kern_xxx() no-at variants. In-Reply-To: <201411121014.04482.jhb@freebsd.org> Message-ID: References: <20141112132451.GM17068@kib.kiev.ua> <201411121014.04482.jhb@freebsd.org> User-Agent: Alpine 1.10 (GSO 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplleLIzCtJLcpLzFFi42IRYrdT0fXblRxi0NYnYrFkxjxmi9nTpzFZ HH7iYrH3yHVmi4Zpj9kcWD1mfJrP4rFz1l32AKYoLpuU1JzMstQifbsEroy3T3awFPRwVqye 9ouxgXEWexcjB4eEgInEjPXhXYycQKaYxIV769m6GLk4hARmM0ks/fODGcLZyCjxsGc6C0iV kMAhJom31wMhEg2MEj1n1jCBJFgEtCUmXZjHCmKzCahJPN7bzAoxVlFi86lJzCC2iICuxMcF e8BsZoF0iVuXL7GB2MICRhJ7rv8Eq+cUMJTYM+8+WA2vgKPE7DsXWUEuFRIIlbg3MwAkLCqg I7F6/xQWiBJBiZMzn7BAjNSSWD59G8sERqFZSFKzkKQWMDKtYpRNya3SzU3MzClOTdYtTk7M y0st0jXWy80s0UtNKd3ECAptTkm+HYxfDyodYhTgYFTi4eVYlRQixJpYVlyZe4hRkoNJSZT3 0frkECG+pPyUyozE4oz4otKc1OJDjBIczEoivGxLgHK8KYmVValF+TApaQ4WJXHeTT/4QoQE 0hNLUrNTUwtSi2CyMhwcShK8FjuBGgWLUtNTK9Iyc0oQ0kwcnCDDeYCGf9oBMry4IDG3ODMd In+KUVFKnHc2SEIAJJFRmgfXC0s9rxjFgV4R5tUFWcEDTFtw3a+ABjMBDf4WngQyuCQRISXV wOi/aXWwgdjnK+smewZO+7/K3KFCKFNjlm6rt9IsMXtprbx7bwWz0mQq9bruNSn2HbeL0d/i Ene1TPmE307zlY+T/8SHTLX/l7TIYeJFqciS0v3fS/cJuGcsEr678liKmUr9bx3V+ky9yupL F1yPb1YyFJZ4K+X1bJrbmwcLZrWd8eP79vQwmxJLcUaioRZzUXEiAJDMi+4YAwAA Cc: arch@freebsd.org, fs@freebsd.org, freebsd-arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Nov 2014 19:51:51 -0000 On Wed, 12 Nov 2014, John Baldwin wrote: > On Wednesday, November 12, 2014 8:24:52 am Konstantin Belousov wrote: > > We have 'fat' KPI for kern_open() and other vfs syscall helpers, after > > the at-version of the syscalls was added somewhere at 8-CURRENT. > > For instance, we provide > > kern_open() and kern_openat(). > > But more, we provide > > kern_stat() > > kern_lstat() > > kern_statat() > > kern_statat_vhook() > > first three being a trivial wrapper around kern_statat_vhook(). > > More, existence of two or (sometimes) three layers around basic > > syscall helper causes issues like r271655 making the argument > > validation split. > > > > Kepping the compat layer was reasonable in 8-CURRENT time when the > > at variants were experimental and patch to add the syscalls was > > already large and error-prone. Now, I think we should shave the > > extra call indirections, it costs nothing at callers and sometimes > > even improves the code. > > The idea sounds fine to me. Note that I only did a glance over the diff > rather than a thorough review. Please do bump __FreeBSD_version along with the change. -Ben