From nobody Wed Jun 18 02:13:16 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bMS2P5X9Tz5q6k4; Wed, 18 Jun 2025 02:13:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bMS2N6pM8z41Bk; Wed, 18 Jun 2025 02:13:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750212797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bG87H7mWF1DqdT9CtHnUMGQy1mzrEz2CLgekLZd5LTQ=; b=YsGCJ2KkW1y1rBs5kcvgMdPKNBcXrfMqmLpRH79e8/9Mx7aBAt2RJbdaIEP8ngioR+O2xl kz+xsjVTGdhP6TPR5lpbiyqXzv0z2XGY2LPUCeSbqxTjvOy9x3a6hyzqYHsncgaS22G/8j 3J/l7ZmIprNqe2Rv4F2exHQ9wKVqw3lTAKDtsG0kU4x6oDGBw50T8hjc9LWsDmRSGX2heF K2e/GSBD0oizal9EMyN+PfBnc3qvTRhoFiONBWSOfosS6iquALNp43wVtqEH0/p3rK9l/9 NQ8+feBj1yd/nCxrBhSyujVITBzljtMT0gzBFkCZZoxNb101gV4zD2BhcmDWGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750212797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bG87H7mWF1DqdT9CtHnUMGQy1mzrEz2CLgekLZd5LTQ=; b=stYBb1VeiXv8itjLn+d/2VoYJ2sZt1xrqhQjeGWZOYg21lv+DRrBb49+DhVMXa4cA7XpzZ yzH3BGeNTBkAjC/WB/OkTA2lwUS1QHBGnRlZBVFLpKe0B60XWUP5hkn9iVTB7SG8N3iWjl fkpm5Imi6gBd/8u/ZwYb/iXVYQWXq4TjYAUGeVl42OqU/Ov2E+4Me4HS0U9My2N/nt6UV5 9psOq/6ht9rk43T4gYadoE35hREmZcbQBLJMAV89MVssXfStg4pXEhpxWnUkE8yMaprJxD yhxsoxZtGu5wvUQRjXOCC/rdtUIM4P9LAH/vbYFe87Jopzsqn0QPHCYYJb6x/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1750212797; a=rsa-sha256; cv=none; b=wQjAFXDelvDU5HkZRaKuostwxmjaDHxOAHA6ovj+rFwlPnVGuptRvmI+OZqqB6MSs0o/Yq qWVtwWaLElhISgNQw8XfisE/V5QRZvnTaVHtfFbySwTkO6eie7IbOG+ciOWIQwkdofmrye Vs04/FVqmQj045rBqvcnpB0wYM1LbluMrG+4/FYnicOZxVmPahxvAnn1mlnNxOiiqvH594 WuFOydRK38bDSp/ihnGpesdR5GJcIY/cTr+BDRI2EyusFyQKC8BPgT7N/7Srpk864emRzw Aavv8FuxlEb8fwfCZ83oGw82cvtFBpBarPfSd+XCdLW71wBmiD642ESm81UFpA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bMS2N6M31z18SB; Wed, 18 Jun 2025 02:13:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55I2DGDx024201; Wed, 18 Jun 2025 02:13:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55I2DGdV024198; Wed, 18 Jun 2025 02:13:16 GMT (envelope-from git) Date: Wed, 18 Jun 2025 02:13:16 GMT Message-Id: <202506180213.55I2DGdV024198@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: de78657a3aef - main - runq: runq_check(): Re-implement on top of runq_findq() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: de78657a3aef3c2efbcbdf9ea73a95283c91fab0 Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=de78657a3aef3c2efbcbdf9ea73a95283c91fab0 commit de78657a3aef3c2efbcbdf9ea73a95283c91fab0 Author: Olivier Certner AuthorDate: 2024-02-29 18:10:58 +0000 Commit: Olivier Certner CommitDate: 2025-06-18 02:07:59 +0000 runq: runq_check(): Re-implement on top of runq_findq() Remove one more loop and duplicated code, with the benefit of less instruction cache pollution at the expense of a few cycles more for the function calls and computing 'idx' (however, this gives a better diagnostic message). Reviewed by: kib MFC after: 1 month Event: Kitchener-Waterloo Hackathon 202506 Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D45387 --- sys/kern/kern_switch.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/sys/kern/kern_switch.c b/sys/kern/kern_switch.c index a321aecc55fb..59925c10c30d 100644 --- a/sys/kern/kern_switch.c +++ b/sys/kern/kern_switch.c @@ -445,17 +445,15 @@ runq_findq(struct runq *const rq) bool runq_not_empty(struct runq *rq) { - struct rq_status *rqs; + int idx; - rqs = &rq->rq_status; - for (int i = 0; i < RQSW_NB; i++) - if (rqs->rq_sw[i] != 0) { - CTR2(KTR_RUNQ, "runq_not_empty: bits=%#x i=%d", - rqs->rq_sw[i], i); - return (true); - } - CTR0(KTR_RUNQ, "runq_not_empty: empty"); + idx = runq_findq(rq); + if (idx != -1) { + CTR1(KTR_RUNQ, "runq_not_empty: idx=%d", idx); + return (true); + } + CTR0(KTR_RUNQ, "runq_not_empty: empty"); return (false); }