From owner-svn-src-head@FreeBSD.ORG Thu Mar 15 22:53:40 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A1253106566C; Thu, 15 Mar 2012 22:53:40 +0000 (UTC) (envelope-from nwhitehorn@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 8F85D8FC0A; Thu, 15 Mar 2012 22:53:40 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q2FMregu086995; Thu, 15 Mar 2012 22:53:40 GMT (envelope-from nwhitehorn@svn.freebsd.org) Received: (from nwhitehorn@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q2FMreAK086987; Thu, 15 Mar 2012 22:53:40 GMT (envelope-from nwhitehorn@svn.freebsd.org) Message-Id: <201203152253.q2FMreAK086987@svn.freebsd.org> From: Nathan Whitehorn Date: Thu, 15 Mar 2012 22:53:40 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r233018 - in head/sys: dev/ofw dev/pcf powerpc/ofw sparc64/pci X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2012 22:53:40 -0000 Author: nwhitehorn Date: Thu Mar 15 22:53:39 2012 New Revision: 233018 URL: http://svn.freebsd.org/changeset/base/233018 Log: Make ofw_bus_get_node() consistently return -1 when there is no associated OF node, instead of a random mixture of 0 and -1. Update all checks for 0 to check for -1 instead. MFC after: 4 weeks Modified: head/sys/dev/ofw/ofw_bus_if.m head/sys/dev/ofw/ofw_bus_subr.c head/sys/dev/ofw/ofw_iicbus.c head/sys/dev/pcf/pcf_ebus.c head/sys/powerpc/ofw/ofw_pcib_pci.c head/sys/powerpc/ofw/ofw_pcibus.c head/sys/sparc64/pci/ofw_pcibus.c Modified: head/sys/dev/ofw/ofw_bus_if.m ============================================================================== --- head/sys/dev/ofw/ofw_bus_if.m Thu Mar 15 22:50:48 2012 (r233017) +++ head/sys/dev/ofw/ofw_bus_if.m Thu Mar 15 22:53:39 2012 (r233018) @@ -89,7 +89,7 @@ CODE { ofw_bus_default_get_node(device_t bus, device_t dev) { - return (0); + return (-1); } static const char * Modified: head/sys/dev/ofw/ofw_bus_subr.c ============================================================================== --- head/sys/dev/ofw/ofw_bus_subr.c Thu Mar 15 22:50:48 2012 (r233017) +++ head/sys/dev/ofw/ofw_bus_subr.c Thu Mar 15 22:53:39 2012 (r233018) @@ -157,7 +157,7 @@ ofw_bus_is_compatible(device_t dev, cons if ((compat = ofw_bus_get_compat(dev)) == NULL) return (0); - if ((node = ofw_bus_get_node(dev)) == 0) + if ((node = ofw_bus_get_node(dev)) == -1) return (0); /* Get total 'compatible' prop len */ Modified: head/sys/dev/ofw/ofw_iicbus.c ============================================================================== --- head/sys/dev/ofw/ofw_iicbus.c Thu Mar 15 22:50:48 2012 (r233017) +++ head/sys/dev/ofw/ofw_iicbus.c Thu Mar 15 22:53:39 2012 (r233018) @@ -88,7 +88,7 @@ static int ofw_iicbus_probe(device_t dev) { - if (ofw_bus_get_node(dev) == 0) + if (ofw_bus_get_node(dev) == -1) return (ENXIO); device_set_desc(dev, "OFW I2C bus"); Modified: head/sys/dev/pcf/pcf_ebus.c ============================================================================== --- head/sys/dev/pcf/pcf_ebus.c Thu Mar 15 22:50:48 2012 (r233017) +++ head/sys/dev/pcf/pcf_ebus.c Thu Mar 15 22:53:39 2012 (r233018) @@ -147,7 +147,7 @@ pcf_ebus_attach(device_t dev) mtx_init(&sc->pcf_lock, device_get_nameunit(dev), "pcf", MTX_DEF); /* get OFW node of the pcf */ - if ((node = ofw_bus_get_node(dev)) <= 0) { + if ((node = ofw_bus_get_node(dev)) == -1) { device_printf(dev, "cannot get OFW node\n"); goto error; } Modified: head/sys/powerpc/ofw/ofw_pcib_pci.c ============================================================================== --- head/sys/powerpc/ofw/ofw_pcib_pci.c Thu Mar 15 22:50:48 2012 (r233017) +++ head/sys/powerpc/ofw/ofw_pcib_pci.c Thu Mar 15 22:53:39 2012 (r233018) @@ -93,7 +93,7 @@ ofw_pcib_pci_probe(device_t dev) return (ENXIO); } - if (ofw_bus_get_node(dev) == 0) + if (ofw_bus_get_node(dev) == -1) return (ENXIO); device_set_desc(dev, "OFW PCI-PCI bridge"); Modified: head/sys/powerpc/ofw/ofw_pcibus.c ============================================================================== --- head/sys/powerpc/ofw/ofw_pcibus.c Thu Mar 15 22:50:48 2012 (r233017) +++ head/sys/powerpc/ofw/ofw_pcibus.c Thu Mar 15 22:53:39 2012 (r233018) @@ -105,7 +105,7 @@ static int ofw_pcibus_probe(device_t dev) { - if (ofw_bus_get_node(dev) == 0) + if (ofw_bus_get_node(dev) == -1) return (ENXIO); device_set_desc(dev, "OFW PCI bus"); Modified: head/sys/sparc64/pci/ofw_pcibus.c ============================================================================== --- head/sys/sparc64/pci/ofw_pcibus.c Thu Mar 15 22:50:48 2012 (r233017) +++ head/sys/sparc64/pci/ofw_pcibus.c Thu Mar 15 22:53:39 2012 (r233018) @@ -111,7 +111,7 @@ static int ofw_pcibus_probe(device_t dev) { - if (ofw_bus_get_node(dev) == 0) + if (ofw_bus_get_node(dev) == -1) return (ENXIO); device_set_desc(dev, "OFW PCI bus");