Date: Thu, 15 Mar 2018 09:46:15 -0600 From: Ian Lepore <ian@freebsd.org> To: rgrimes@freebsd.org, Andriy Gapon <avg@freebsd.org> Cc: Eitan Adler <eadler@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r330972 - stable/11/share/misc Message-ID: <1521128775.99081.34.camel@freebsd.org> In-Reply-To: <201803151533.w2FFXkS9093662@pdx.rh.CN85.dnsmgr.net> References: <201803151533.w2FFXkS9093662@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2018-03-15 at 08:33 -0700, Rodney W. Grimes wrote: > > > > On 15/03/2018 10:30, Eitan Adler wrote: > > > > > > Author: eadler > > > Date: Thu Mar 15 08:30:05 2018 > > > New Revision: 330972 > > > URL: https://svnweb.freebsd.org/changeset/base/330972 > > > > > > Log: > > > MFC r303063,r311852,r311930,r317040,r320506,r321301,r325162,r326759,r329004,: > > I have never seen things like these MFC-ed before... > > Should we be really doing them? > Yes, imho. And the reasons may seem odd to sum, but here is my spin on this: > > It should not of been Eitan who did the MFC. > > Second, this simple document MFC is excellent training ground for a new > commiter to learn how to do a MFC. Everyone should know how to do an MFC > and it seems we have many (me included when I returned as my experiece was > all with cvs, not svn) who do not know how to do this operation. > > If they mess up this simple text file it has a very low risk, and then > they can learn how to do a revert and recommit! > > Maybe we should even add to the end of the commiters "these are the > things you should do as a new committer" the merging of your info > into to all supported/active releases. Which is a good opportunity > for teaching how to do svn sparse checkouts as you really do not > want to pull all of stable/10 out just to commit to 1 file. > > This file is an excellent opportunity for training, lets USE IT! > > Thanks, I agree completely with all of this. It bothers me how many committers have the attitude that handling MFCs is not part of being a committer. While I stop short of any kind of inflexible rule requiring all committers to attend to their own MFCs, anything we can do to encourage it and make it part of the culture is a good thing. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1521128775.99081.34.camel>