Date: Fri, 13 Jan 2006 20:20:49 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Xin LI <delphij@FreeBSD.org> Cc: arch@FreeBSD.org, re@FreeBSD.org Subject: Re: review: patch to restore VLAN kernel API in RELENG_6 Message-ID: <20060113172049.GG83922@cell.sick.ru> In-Reply-To: <20060113171759.GA1255@hub.freebsd.org> References: <20060113170552.GF83922@FreeBSD.org> <20060113171759.GA1255@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 13, 2006 at 05:17:59PM +0000, Xin LI wrote:
X> Hi, Gleb,
X> > ===================================================================
X> > RCS file: /home/ncvs/src/sys/dev/bge/if_bge.c,v
X> > retrieving revision 1.91.2.7
X> > diff -u -r1.91.2.7 if_bge.c
X> > --- sys/dev/bge/if_bge.c 13 Jan 2006 11:51:08 -0000 1.91.2.7
X> > +++ sys/dev/bge/if_bge.c 13 Jan 2006 17:04:31 -0000
X> > @@ -2862,7 +2862,7 @@
X> > * attach that information to the packet.
X> > */
X> > if (have_tag) {
X> > - VLAN_INPUT_TAG(ifp, m, vlan_tag);
X> > + VLAN_INPUT_TAG_NEW(ifp, m, vlan_tag);
X>
X> What if "VLAN_INPUT_TAG_2" or something with numerical name?
X>
X> Just my $0.02, though :-)
I really don't care. :)
--
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060113172049.GG83922>