From owner-svn-src-head@freebsd.org Tue May 3 23:03:38 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60263B2C25D; Tue, 3 May 2016 23:03:38 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4A1821816; Tue, 3 May 2016 23:03:37 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id u43N3a8s095721 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 3 May 2016 16:03:37 -0700 (PDT) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id u43N3auS095720; Tue, 3 May 2016 16:03:36 -0700 (PDT) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 3 May 2016 16:03:36 -0700 From: Gleb Smirnoff To: Michael Tuexen Cc: Ian Lepore , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r298187 - head/sys/netinet Message-ID: <20160503230336.GD1369@FreeBSD.org> References: <201604180638.u3I6cs5P043229@repo.freebsd.org> <1460992087.52955.47.camel@freebsd.org> <0BC0F7D1-9523-4FE6-A6ED-57372CC80206@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0BC0F7D1-9523-4FE6-A6ED-57372CC80206@freebsd.org> User-Agent: Mutt/1.6.0 (2016-04-01) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2016 23:03:38 -0000 Michael, On Mon, Apr 18, 2016 at 06:56:29PM +0200, Michael Tuexen wrote: M> > On Mon, 2016-04-18 at 06:38 +0000, Michael Tuexen wrote: M> >> Author: tuexen M> >> Date: Mon Apr 18 06:38:53 2016 M> >> New Revision: 298187 M> >> URL: https://svnweb.freebsd.org/changeset/base/298187 M> >> M> >> Log: M> >> Don't use anonymous unions. M> >> M> > M> > Why not? This is one of those commit messages that really needs to say M> Because the same code is used in a userland SCTP stack and that M> uses C99. Anonymous unions are introduced in C11. That's why. This explanation of course emerges next question :) Why don't enable C11 when compiling the userland SCTP stack? -- Totus tuus, Glebius.