From owner-freebsd-bugs@FreeBSD.ORG Fri Jan 25 17:28:06 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E51E16A418; Fri, 25 Jan 2008 17:28:06 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 0419513C4D1; Fri, 25 Jan 2008 17:28:06 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from freefall.freebsd.org (rwatson@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m0PHS5lJ075919; Fri, 25 Jan 2008 17:28:05 GMT (envelope-from rwatson@freefall.freebsd.org) Received: (from rwatson@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m0PHS5F3075915; Fri, 25 Jan 2008 17:28:05 GMT (envelope-from rwatson) Date: Fri, 25 Jan 2008 17:28:05 GMT Message-Id: <200801251728.m0PHS5F3075915@freefall.freebsd.org> To: oleg@reis.zp.ua, rwatson@FreeBSD.org, freebsd-bugs@FreeBSD.org From: rwatson@FreeBSD.org Cc: Subject: Re: bin/40282: /bin/kill has bad error checking for command line parameters X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2008 17:28:06 -0000 Synopsis: /bin/kill has bad error checking for command line parameters State-Changed-From-To: open->analyzed State-Changed-By: rwatson State-Changed-When: Fri Jan 25 17:24:00 UTC 2008 State-Changed-Why: If we want to make a change along these lines, we should change from warnx() to errx(EX_USAGE, ...) rather than changing the loop logic. Does the csh/tcsh kill validate all arguments before starting the killing (so to speak), or does it abort when it hits the first bad one (as this patch suggests)? http://www.freebsd.org/cgi/query-pr.cgi?pr=40282