From owner-svn-src-head@FreeBSD.ORG Sun Sep 16 17:46:04 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3C923106566B; Sun, 16 Sep 2012 17:46:04 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id B68EA8FC12; Sun, 16 Sep 2012 17:46:02 +0000 (UTC) Received: by bkcje9 with SMTP id je9so1952572bkc.13 for ; Sun, 16 Sep 2012 10:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=foLDBXJCXa0lDansQ7xq14N3C9dLa0UmahRpiY7SgIA=; b=eC7C/9fc8LfmV8Lua4mqwUNfaZSf/IdJaDA27TflC8Rd3K9vzlEz/9MndCNnJtwJSC JeZkkCmSaz3m9++d/duVS2JSbTMIUyvaQdjIc2d5CI5zig8JETSOi01VIJwNmo6AvLkL jPMSwo/WJRRsyD10Pd/IzfSoZQCIeTtAjh9JJYLULn+yQEwvDK9TIhXLVUjwERKTteWp r9vh4IjCVMoimENBF2U5iuyOSiKXldp2Pe/pIvWx7qpc0A3s3ukhbscao673EMyYUjuW 98PE4TvQWDSuCSYvrRYzWHTME6X2i6y91goCQMn+awIeFjwcQmTHl+3GApR3D1N5nXip RW+w== Received: by 10.204.145.82 with SMTP id c18mr3508156bkv.133.1347817561299; Sun, 16 Sep 2012 10:46:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.10.141 with HTTP; Sun, 16 Sep 2012 10:45:30 -0700 (PDT) In-Reply-To: <1347817284.1114.2.camel@revolution.hippie.lan> References: <201209160755.q8G7tnMH036332@svn.freebsd.org> <20120916092818.GA81952@FreeBSD.org> <38FB39C4-7626-4D54-8197-E302BB9452D2@FreeBSD.org> <1347817284.1114.2.camel@revolution.hippie.lan> From: Chris Rees Date: Sun, 16 Sep 2012 18:45:30 +0100 Message-ID: To: Ian Lepore Content-Type: text/plain; charset=ISO-8859-1 Cc: Alexey Dokuchaev , src-committers@freebsd.org, svn-src-all@freebsd.org, David Chisnall , Andrew Turner , Bruce Evans , svn-src-head@freebsd.org Subject: Re: svn commit: r240549 - head/sys/arm/tegra X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Sep 2012 17:46:04 -0000 On 16 September 2012 18:41, Ian Lepore wrote: > On Sun, 2012-09-16 at 18:30 +0100, Chris Rees wrote: >> On 16 Sep 2012 16:19, "David Chisnall" wrote: >> > >> > On 16 Sep 2012, at 10:37, Chris Rees wrote: >> > >> > > Actually: >> > > >> > > for (;;) >> > > ; >> > >> > This form will generate a compiler warning, because it looks like a >> missing loop body. You can silence the warning by this form: >> > >> > for (;;) {} >> > >> > This makes it clear that you have an explicit body containing no >> statements. >> >> Please fix the style man page then, and make sure bde approves! > > One of the examples allows > > for (;;) > stmt; > > Using "continue;" as the statement is consistant with that. Ok, so with approval from a docs/src guy I'd like to commit [1] to update the style page to use continue; instead of a lone ; Anyone like to approve/commit? Chris [1] http://www.bayofrum.net/~crees/patches/style-empty-loop.diff