From nobody Fri Sep 22 17:25:36 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RsfL85G8sz4v9QL for ; Fri, 22 Sep 2023 17:25:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RsfL83hmHz4TJ0 for ; Fri, 22 Sep 2023 17:25:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695403536; a=rsa-sha256; cv=none; b=juToyDm93LdEMKJdSbA/CFNJO0AFUZX31AF24KNIUwt9ED58/cbmkP4jxHDEyyrZqzmp0L Tf/LMjovtKNv832lP7CavlmzgST4oF4KoOSD1D7giAdF6hTAKskzyQ3p5vzUnYkRqFzsWa cYWw9naOuAgcoEr0IfvQJPgXs5jv5eVEv2JrBqDX6E3dYwlaumbPN26xD67AGJfhGvzjGv LJ5UIulMXy9k0sGYRAXVFbqOol071fhXuGei50hZie6Tq1LyAOnaWGdCEYDV4Jrdp+MG36 ilvY8GQNUQ6I7BZ77SQ/FbbEOXcszCkb3zJJFUlO7XVeBYB0WevFrjI7bGD6bQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695403536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q+/Blz/09prRS+pXdQx9+qiFeYA9BGQUTdlMh5IPQUU=; b=byX0iLS7ZGbfBeqeni/N+2zlwweTG3NRHtMv5cxwN6TcEUzVcIfS3HeSe2/3yXVIdZHoW7 KhJKzAe1X0niolU8Qzn/qFzrNqhwfV88DnTNLphWcv3OkCSU4CXby+j/N4fGSkcQ1F31qQ R7HK8ySIcWmv9KeV1UGK8eWL6IF9f2d2D49YwaaVhuBPUIuGJpha0wohBhDlzzrbTDwKKI ghOHRoxHmFus8ZqtKZTq3h+lM53MFOL6IKD/JNNl65h62s4b68dQ84fMBqMy6O/iu2nUI+ nBiScnQD85gUlicZoD9lWQzx+RE2hJTa7prPgBf2VLErE4dYMWG/F0weUlWskw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RsfL82pDrzWDx for ; Fri, 22 Sep 2023 17:25:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38MHPaHt064459 for ; Fri, 22 Sep 2023 17:25:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38MHPaGX064458 for bugs@FreeBSD.org; Fri, 22 Sep 2023 17:25:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 273902] Backwards-incompatible size change in struct tcp_info Date: Fri, 22 Sep 2023 17:25:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273902 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D2209676efe9a23d9411fa0314b9c6bb28= 5baefc1 commit 2209676efe9a23d9411fa0314b9c6bb285baefc1 Author: Alan Somers AuthorDate: 2023-09-17 14:22:08 +0000 Commit: Alan Somers CommitDate: 2023-09-22 16:57:03 +0000 Fix padding in struct tcp_info This structure should have the same size across different FreeBSD versions to ensure backwards-compatibility. It has since stable/6. But two recent changes added fields without compensating by reducing padding: 945f9a7cc9dcc071bfcc702748fbbb11087ae773 and 22c81cc51636cfebe94e0979eb31556d87775938 . Reduce padding to compensate. Direct commit to stable/14 because we decided to break compatibility in FreeBSD 15 in order to add more fields. Of course, that decision could be reversed before 15.0-RELEASE. See the review for details. PR: 273902 MFC after: 1 week Reviewed by: tuexen, glebius Differential Revision: https://reviews.freebsd.org/D41894 sys/netinet/tcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=