From owner-freebsd-current@FreeBSD.ORG Wed Jun 8 16:49:22 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6C35516A41C for ; Wed, 8 Jun 2005 16:49:22 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.village.org (berlin-qwest.village.org [168.103.84.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1F5BC43D4C for ; Wed, 8 Jun 2005 16:49:20 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.13.3/8.13.1) with ESMTP id j58Gl8hH017683; Wed, 8 Jun 2005 10:47:10 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 08 Jun 2005 10:47:57 -0600 (MDT) Message-Id: <20050608.104757.39157411.imp@bsdimp.com> To: jeremie@le-hen.org From: "M. Warner Losh" In-Reply-To: <20050608150344.GL41050@obiwan.tataz.chchile.org> References: <20050606155400.GP41050@obiwan.tataz.chchile.org> <20050606.230742.103661451.imp@bsdimp.com> <20050608150344.GL41050@obiwan.tataz.chchile.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Wed_Jun__8_10:47:57_2005_227)--" Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org, bana@sitadelle.com Subject: Re: Can't get MAC addr of an ed(4) adapter X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2005 16:49:22 -0000 ----Next_Part(Wed_Jun__8_10:47:57_2005_227)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit In message: <20050608150344.GL41050@obiwan.tataz.chchile.org> Jeremie Le Hen writes: : Hi Warner, : : On Mon, Jun 06, 2005 at 11:07:42PM -0600, M. Warner Losh wrote: : > : It seems that the ed(4) driver from 2005.01.01 are working well. : > : There have been numerous commits since then, but I'm trying to find : > : the culprit ATM. I'll keep list abreast of the results. : > : > If you find the one that's at issue, I'll be happy to work with you to : > resolve it. : : I narrowed the one breaking MAC address probe : : http://docs.freebsd.org/cgi/getmsg.cgi?fetch=1231599+0+archive/2005/cvs-all/20050220.cvs-all : : I tried to patch the driver myself and I found that you should not clear : pending interrupts before reading the MAC address or it won't work. : : I didn't made a patch as I don't know if the correct way to handle this : is to pull up the ed_nic_outb() call from ed_probe_Novell_generic() to : ed_cbus_probe() or to move the ed_Novell_read_mac() call back in the : ed_probe_Novell_generic() function. Maybe the following patch will be better than either of these alternatives? It adds the call to read the Novel NIC to the pci probe routine, clearly an oversight on the rascal that's responsible for the change that you've pointed out above. :-) Warner ----Next_Part(Wed_Jun__8_10:47:57_2005_227)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="edpci.diff" Index: if_ed_pci.c =================================================================== RCS file: /cache/ncvs/src/sys/dev/ed/if_ed_pci.c,v retrieving revision 1.41 diff -u -r1.41 if_ed_pci.c --- if_ed_pci.c 5 Mar 2005 18:30:10 -0000 1.41 +++ if_ed_pci.c 8 Jun 2005 16:44:24 -0000 @@ -87,6 +87,7 @@ ed_release_resources(dev); return (error); } + ed_Novell_read_mac(sc); error = ed_alloc_irq(dev, 0, RF_SHAREABLE); if (error) { ----Next_Part(Wed_Jun__8_10:47:57_2005_227)----