From owner-svn-src-head@freebsd.org Wed Dec 21 06:40:30 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ADA76C8A033; Wed, 21 Dec 2016 06:40:30 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 8BE5D1964; Wed, 21 Dec 2016 06:40:30 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from Julian-MBP3.local (ppp121-45-237-203.lns20.per1.internode.on.net [121.45.237.203]) (authenticated bits=0) by vps1.elischer.org (8.15.2/8.15.2) with ESMTPSA id uBL6eETb081741 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 20 Dec 2016 22:40:19 -0800 (PST) (envelope-from julian@freebsd.org) Subject: Re: svn commit: r310336 - head/sys/kern To: John Baldwin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201612201944.uBKJiiMg034231@repo.freebsd.org> From: Julian Elischer Message-ID: Date: Wed, 21 Dec 2016 14:40:09 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <201612201944.uBKJiiMg034231@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2016 06:40:30 -0000 On 21/12/2016 3:44 AM, John Baldwin wrote: > Author: jhb > Date: Tue Dec 20 19:44:44 2016 > New Revision: 310336 > URL: https://svnweb.freebsd.org/changeset/base/310336 > > Log: > Don't spin in pause() during early boot for kthreads other than thread0. > > pause() uses a spin loop to simulate a sleep during early boot. However, > we only need this for thread0 to get far enough in the boot process to > enable timers (at which point pause() can sleep). For other kthreads, > sleeping in pause() is ok as the callout will be scheduled and will > eventually fire once thread0 initializes timers. maybe we just need to depend on a variable "have_timers" that is independent of the cold/hot/whatever settings. first code to enable a timer sets it. > > Tested by: Steven Kargl > Sleuthing by: markj > MFC after: 1 week > Sponsored by: Netflix > > Modified: > head/sys/kern/kern_synch.c > > Modified: head/sys/kern/kern_synch.c > ============================================================================== > --- head/sys/kern/kern_synch.c Tue Dec 20 19:30:21 2016 (r310335) > +++ head/sys/kern/kern_synch.c Tue Dec 20 19:44:44 2016 (r310336) > @@ -321,7 +321,8 @@ pause_sbt(const char *wmesg, sbintime_t > if (sbt == 0) > sbt = tick_sbt; > > - if (cold || kdb_active || SCHEDULER_STOPPED()) { > + if ((cold && curthread == &thread0) || kdb_active || > + SCHEDULER_STOPPED()) { > /* > * We delay one second at a time to avoid overflowing the > * system specific DELAY() function(s): > >