From owner-freebsd-ports@freebsd.org Tue Apr 5 21:08:43 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F0DCBB047BD for ; Tue, 5 Apr 2016 21:08:43 +0000 (UTC) (envelope-from michelle@sorbs.net) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id DF99B107D for ; Tue, 5 Apr 2016 21:08:43 +0000 (UTC) (envelope-from michelle@sorbs.net) Received: by mailman.ysv.freebsd.org (Postfix) id DB468B047BC; Tue, 5 Apr 2016 21:08:43 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DAEE3B047BB for ; Tue, 5 Apr 2016 21:08:43 +0000 (UTC) (envelope-from michelle@sorbs.net) Received: from hades.sorbs.net (mail.sorbs.net [67.231.146.200]) by mx1.freebsd.org (Postfix) with ESMTP id CEC07107C for ; Tue, 5 Apr 2016 21:08:43 +0000 (UTC) (envelope-from michelle@sorbs.net) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Received: from isux.com (firewall.isux.com [213.165.190.213]) by hades.sorbs.net (Oracle Communications Messaging Server 7.0.5.29.0 64bit (built Jul 9 2013)) with ESMTPSA id <0O5600M4WJ2HMR00@hades.sorbs.net> for ports@freebsd.org; Tue, 05 Apr 2016 14:15:55 -0700 (PDT) Subject: Re: Committer needed for PR 208029 To: Kurt Jaeger , Martin Waschbuesch , ports@freebsd.org References: <498CA3F8-15EF-45BD-880C-241F83CBE3DD@waschbuesch.de> <20160405185159.GK35640@home.opsec.eu> <20160405200835.GM35640@home.opsec.eu> From: Michelle Sullivan Message-id: <57042958.5010701@sorbs.net> Date: Tue, 05 Apr 2016 23:08:40 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40 In-reply-to: <20160405200835.GM35640@home.opsec.eu> X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2016 21:08:44 -0000 Kurt Jaeger wrote: > Hi! > >> I'm testbuilding those ports right now and find that >> they fail on 9.3amd64 with: > With this in the -server Makefile, all is fine. > > .if ${OPSYS} == FreeBSD && ${OSVERSION} < 1000000 > WITH_OPENSSL_PORT=yes > .endif > Umm probably a really bad idea... consider this or something more creative/descriptive: .if ${OPSYS} == FreeBSD && ${OSVERSION} < 1000000 && ${WITH_OPENSSL_PORT} != "yes" BROKEN= You must set WITH_OPENSSL_PORT=yes in /etc/make.conf on Pre 10.x .endif ... the idea instead of silently turning it on which could cause a myriad of hell for production systems where some ports are compiled against security/openssl and some against the base openssl... stop the compile and tell the user what they have to do to resolve it... which will then make anything else use the same openssl and lessen the dependency/library issues that could happen. Regards, -- Michelle Sullivan http://www.mhix.org/