From owner-freebsd-gnome@freebsd.org Wed Aug 10 00:28:41 2016 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2FAEBBB4CCB for ; Wed, 10 Aug 2016 00:28:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 1974F1222 for ; Wed, 10 Aug 2016 00:28:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 153EBBB4CCA; Wed, 10 Aug 2016 00:28:41 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14E34BB4CC8 for ; Wed, 10 Aug 2016 00:28:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DEF4F1221 for ; Wed, 10 Aug 2016 00:28:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u7A0Se2a022295 for ; Wed, 10 Aug 2016 00:28:40 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 211684] audio/pulseaudio: Respect hw.snd.default_unit Date: Wed, 10 Aug 2016 00:28:40 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: t@tobik.me X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2016 00:28:41 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211684 --- Comment #2 from Tobias Kortkamp --- (In reply to lightside from comment #1) Hi Lightside, thanks for looking into it. Your patch works but has a big flaw in that it only creates a sink for the default device. The other devices are skipped. That's a big divergence from the current behavior. Users might want to switch streams to a specific sink (OSS device). Given that it only creates one sink, there is no point in even reading /dev/sndstat anymore as we could just create one sink for /dev/dsp. Since you went to the trouble of recreating the patch in a different way, I'd like to know why you dismissed my approach? What's wrong with it in your eyes? I ask because I'm willing to do the work on this one, even for PulseAudio 9.0, if someone tells me what to change and explains why. Let me summarize my POV of what the requirements of this are: 1. PulseAudio does not respect hw.snd.default_unit and does not set its default sink to the sink corresponding to the default device. 2. PulseAudio uses the first sink as the default sink by default, so one way to force PulseAudio to use it, is by adding the default device first. 3. That's what I did with my patch, but since /dev/dsp will appear again in /dev/sndstat with a different name we get a duplicated device in the sink list. If we don't want that, we need to add the default device first, then all the others. Your patch is half of that solution. There needs to be e.g. a second loop over /dev/sndstat after the first one. 4. Not adding /dev/dsp to the sink list means changes to hw.snd.default_unit are not picked up by the PulseAudio daemon anymore without restarting it. 5. But we also absolutely want to have corresponding sinks for ALL other OSS devices in PulseAudio to retain the current flexibility. --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.=