From owner-cvs-all  Wed Nov 13  9:48:44 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2AD8237B401; Wed, 13 Nov 2002 09:48:43 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DFF9B43E77; Wed, 13 Nov 2002 09:48:42 -0800 (PST)
	(envelope-from nectar@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id gADHkFmV049245;
	Wed, 13 Nov 2002 09:46:15 -0800 (PST)
	(envelope-from nectar@repoman.freebsd.org)
Received: (from nectar@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id gADHkF68049244;
	Wed, 13 Nov 2002 09:46:15 -0800 (PST)
Message-Id: <200211131746.gADHkF68049244@repoman.freebsd.org>
From: Jacques Vidrine <nectar@FreeBSD.org>
Date: Wed, 13 Nov 2002 09:46:15 -0800 (PST)
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: cvs commit: src/lib/libpam/modules/pam_krb5 pam_krb5.c
X-FreeBSD-CVS-Branch: HEAD
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

nectar      2002/11/13 09:46:15 PST

  Modified files:
    lib/libpam/modules/pam_krb5 pam_krb5.c 
  Log:
  The pam_krb5 module stored a reference to a krb5_ccache structure as
  PAM module state (created in pam_sm_authenticate and referenced later
  in pam_sm_setcred and pam_sm_acct_mgmt).  However, the krb5_ccache
  structure shares some data members with the krb5_context structure
  that was used in its creation.  Since a new krb5_context is created
  and destroyed at each PAM entry point, this inevitably caused the
  krb5_ccache structure to reference free'd memory.
  
  Now instead of storing a pointer to the krb5_ccache structure,
  we store the name of the cache (e.g. `MEMORY:0x123CACHE') in
  pam_sm_authenticate, and resolve the name in the other entry points.
  
  This bug was uncovered by phkmalloc's free'd memory scrubbing.
  
  Approved by:    re (jhb)
  
  Revision  Changes    Path
  1.11      +42 -20    src/lib/libpam/modules/pam_krb5/pam_krb5.c

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message