From owner-freebsd-fs@freebsd.org Wed Mar 6 17:26:04 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C3E201520A6B for ; Wed, 6 Mar 2019 17:26:04 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8441F954EC; Wed, 6 Mar 2019 17:26:04 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-ot1-f43.google.com with SMTP id m1so11462567otf.5; Wed, 06 Mar 2019 09:26:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2cSbwx0Yua2fGe5qLHYoyzXwEyp+qhmk9hsVslK0RQA=; b=hC7bzKqqYyAw/wkfHpL/ZWMBCGgxQjQ/VQOBal8fU6alVI1oawlZXTQL0oXuaOVOce GRsLcBIgc0d4JxRZsFis5VoV8URQUWLxzUptOKVeO5dstFXgFUvOmxYCkE8MaMMkSfCQ M/c5kT2Dr9ZQ0Q2aX7G4iZ13yZVI09nxHNetd9ayls2vj/oQIYFHsHR0ZHROrxhZjtgM ooIH/4H+uCBjOJVPcxF0OPOrYDeSxMsV2Nq4HLOYf7YPJDw+i2tLB2C3URNnEJhEY6d3 nunlGJ6WNKYYnTAkHgGoxFDXXZI5RUCIFrkNNwB0o72pLgcBn4pCahl9lv9ksi9/6s0u lp1Q== X-Gm-Message-State: APjAAAXCsTTnlMNblvaX59UrloXreqIlms0DHw5QY3vle7qm/MAypnvz p9rfZNvVld06+vvg6AjyMOUOvxs01xI3NqfZg1CkIw== X-Google-Smtp-Source: APXvYqzjyAG/InMVCWePq+ppCLN3orT6MqsjnWlnEed7bC4Vn7ZQ1FC3HU2ncP++9BodPkhwNSYlob6cfDomLtcx4yk= X-Received: by 2002:a05:6830:1193:: with SMTP id u19mr5035898otq.221.1551893157803; Wed, 06 Mar 2019 09:25:57 -0800 (PST) MIME-Version: 1.0 References: <201903052008.x25K8d4Z011653@chez.mckusick.com> <169532d2770.27fa.fa4b1493b064008fe79f0f905b8e5741@Leidinger.net> <20190306145031.GC2492@kib.kiev.ua> In-Reply-To: <20190306145031.GC2492@kib.kiev.ua> From: Edward Napierala Date: Wed, 6 Mar 2019 17:25:46 +0000 Message-ID: Subject: Re: 'td' vs sys/fs/nfsserver/ To: Konstantin Belousov Cc: Alexander Leidinger , Kirk McKusick , FreeBSD FS Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 8441F954EC X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.86 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.86)[-0.858,0] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2019 17:26:04 -0000 On Wed, 6 Mar 2019 at 14:50, Konstantin Belousov wrote: > > On Wed, Mar 06, 2019 at 02:25:16PM +0100, Alexander Leidinger via freebsd-fs wrote: [..] > > To make it explicit what my intend is with those questions: I suggest to > > look at real numbers and quality, instead of expectations and feelings. > Good luck measuring frustration. We can try to estimate it, though. Actually removing the 'td' argument throughout the kernel would not only introduce code churn (which is a valid concern of course), but it would create one huge merge conflict (or, if spread over time, a series of merge conflicts) for literally everyone. That's a lot of frustration. On the other hand, I'd expect cleaning up the top of the stack to make it easy to stop passing the td in newly written code - by making it very clear, and perhaps assertable, that for a given KPI it's always equal to curthread - to be more acceptable. It would also make it possible, in future, to remove the td in selected places, where it eg causes a stack spill.