From owner-freebsd-ports@freebsd.org Tue Dec 25 18:04:48 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 248C31358591 for ; Tue, 25 Dec 2018 18:04:48 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0318B851D8 for ; Tue, 25 Dec 2018 18:04:46 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-yb1-xb34.google.com with SMTP id 2so3758075ybw.4 for ; Tue, 25 Dec 2018 10:04:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=SGn+PUasXy1EhhM/cFKcAq6hWjHhAukL5P24MeEXOA0=; b=QUTQJilQPXgTnFwB0PISD9/ZCHXs0g5MsDfn00eT7b6zop8X71uGX+EECdri0WS640 LM3wZvbkNz6wVttp4hZ5H3ydeR+1Suv/VievWehhtutNYhmhGxaiPjL0VCefi7Uf53J5 Xo4LFC45S4JsMVbYdDs/IXUYfq0q03DyolVvPxZqql5J9zNabvRo1teyAGCZPc1FwGBP G1FZnbGZOHC/OqzUPcR+MNQy5e4z7jMsr6szciP0WnQpPu+H3/iTV678Q5pYYtKLdJ/T CgLrEDGEjFUJNfp9ZFSMMDUHhWIqLMCzjJyb9uOkH0tB7tvnRbyquxYiYylQBK7IXa9I ZyGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=SGn+PUasXy1EhhM/cFKcAq6hWjHhAukL5P24MeEXOA0=; b=WmuGDZXjmfmieKbjhheO8SdjX7QgssH6aRBz43/Zh7IquyBYoAu/Ny2GBdPrPuxKta yrxmOQ/impPGcbVZiQxfKth+lsd7dWWhDLvhZ8e7/7YIR5ojFtFi4RArmidL+mCeOTk/ qT4hGtZMqjYNfznpf6HgFux2ivfRk7+gjAKr1guyrwvEh+KPfXunTgPk/HdYsTxXdL7p FLwqxJACjAMIRM1Ew9RNLqIi+6eGFP3OrvlJ69oyRWT44lM+O+v/6HuBhgTN5aWLgBhN QHxG9ksYwUvf1KpZyA6W+kfXO5OAbLtj/CrbrcxuLjA5L5EWeWbAsq/8pwAMDGpp4OMJ raTA== X-Gm-Message-State: AJcUukc5wgh1S+/b17Fe7pDn1yIupEoXXAvNOdDShF0LWk5+fuxMzZw7 fnblEyXLRuZHr/GCiocdMzTReGbPaVpGnJjUpy1CuQ== X-Google-Smtp-Source: ALg8bN5IoRunfCo44hVnp2rgtbzDiMZpytfeqOcED/o0dTPOdkBhOq6F/Y2lEMRDDDRKpAXC7FKoNe5Yz4v1PKjqKD0= X-Received: by 2002:a25:3411:: with SMTP id b17mr12573550yba.197.1545761086088; Tue, 25 Dec 2018 10:04:46 -0800 (PST) MIME-Version: 1.0 References: <9AEEB09B-1D3F-48E6-BEDD-ECABAEA13A40@gmail.com> In-Reply-To: <9AEEB09B-1D3F-48E6-BEDD-ECABAEA13A40@gmail.com> From: Adam Weinberger Date: Tue, 25 Dec 2018 11:04:30 -0700 Message-ID: Subject: Re: Question regarding diffs of ports that need UIDs and GIDs To: Michael Chiu Cc: freebsd-ports@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0318B851D8 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=adamw-org.20150623.gappssmtp.com header.s=20150623 header.b=QUTQJilQ; spf=pass (mx1.freebsd.org: domain of adamw@adamw.org designates 2607:f8b0:4864:20::b34 as permitted sender) smtp.mailfrom=adamw@adamw.org X-Spamd-Result: default: False [-5.97 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[adamw-org.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; DMARC_NA(0.00)[adamw.org]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_SHORT(-0.94)[-0.944,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[adamw-org.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[4.3.b.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; MX_GOOD(-0.01)[alt1.aspmx.l.google.com,aspmx.l.google.com,alt3.aspmx.l.google.com,alt2.aspmx.l.google.com,alt4.aspmx.l.google.com]; IP_SCORE(-2.52)[ip: (-9.17), ipnet: 2607:f8b0::/32(-1.85), asn: 15169(-1.48), country: US(-0.08)]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Dec 2018 18:04:48 -0000 On Tue, Dec 25, 2018 at 10:41 AM Michael Chiu wrote: > > > Hi! > > I=E2=80=99m creating a port which required to create a UID and GID to set= the right permission of files and to lower the permission when the program= start as daemon. I followed the Porter=E2=80=99s Handbook which mentioned = how to create .diff files for the port. > > However, it does not mention anything about what porter should do when th= e UIDs and GIDs files were modified. > > Should I create a single .diff file which contains both changes to the po= rt and UIDs/GIDs files, or if I should create 3 diff files, one for the por= t, one for the UIDs and one for the GIDs? > > Michael. Hi Michael, Great question! You can put all the changes into a single patch (make sure to run diff from /usr/ports/). One diff makes it easier for committers to see and apply the changes. # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org