From owner-svn-src-head@freebsd.org Mon Aug 24 08:26:38 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8601A9BF8FB; Mon, 24 Aug 2015 08:26:38 +0000 (UTC) (envelope-from ermal.luci@gmail.com) Received: from mail-yk0-x22e.google.com (mail-yk0-x22e.google.com [IPv6:2607:f8b0:4002:c07::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 40FF31EBB; Mon, 24 Aug 2015 08:26:38 +0000 (UTC) (envelope-from ermal.luci@gmail.com) Received: by ykfw73 with SMTP id w73so127420621ykf.3; Mon, 24 Aug 2015 01:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=jZCcd0OBJ4hGTljU/eM9lmW99AyXMiB+3Lwpoie4G40=; b=QowTyU5YfP0B/I1vNiyp0hJrpQ3Xtr3m/hGMhiPmqeuMFbekS9cZbcneYBuAPwKJzw AaQQJkS4ZjI2YBCgcsLwxIYciQ6vnzCVHaNUiVJpUe2cFjZhZXoo4C5mOKfufEtaU5cS Qtv6PrPK6VLk8zUhJ7qxljYHQorzItknZSg1kOkBCieRNDMAI63JZKhPhToI9Syl3QP+ oX8zb3JY8POCSKRWxgahi5H9c+2/TSXNtnWdgyTfXJul987jkJNk4dJrqW5kP2mfM6TE F0lh4xs21mtcZzVtjSBaiQSL5bukyrw8Tx4xYxkky6vk0cHgpo903Hh5cXAr9CFqykb6 Ncaw== MIME-Version: 1.0 X-Received: by 10.170.190.136 with SMTP id h130mr27397661yke.70.1440404797268; Mon, 24 Aug 2015 01:26:37 -0700 (PDT) Received: by 10.129.73.205 with HTTP; Mon, 24 Aug 2015 01:26:37 -0700 (PDT) In-Reply-To: References: <201508212202.t7LM2MhF015522@repo.freebsd.org> Date: Mon, 24 Aug 2015 10:26:37 +0200 Message-ID: Subject: Re: svn commit: r287009 - in head: sbin/pfctl share/man/man4 sys/conf sys/net/altq sys/netpfil/pf From: =?UTF-8?Q?Ermal_Lu=C3=A7i?= To: Luiz Otavio O Souza Cc: Luiz Otavio O Souza , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2015 08:26:38 -0000 On Sun, Aug 23, 2015 at 12:34 AM, Luiz Otavio O Souza wrote: > On Sat, Aug 22, 2015 at 6:18 AM, Ermal Lu=C3=A7i wrote: > > > > > > On Sat, Aug 22, 2015 at 12:02 AM, Luiz Otavio O Souza > > wrote: > >> > >> Author: loos > >> Date: Fri Aug 21 22:02:22 2015 > >> New Revision: 287009 > >> URL: https://svnweb.freebsd.org/changeset/base/287009 > >> > >> Log: > >> Add ALTQ(9) support for the CoDel algorithm. > >> > >> CoDel is a parameterless queue discipline that handles variable > >> bandwidth > >> and RTT. > >> > >> It can be used as the single queue discipline on an interface or as = a > >> sub > >> discipline of existing queue disciplines such as PRIQ, CBQ, HFSC, > FAIRQ. > >> > >> Differential Revision: https://reviews.freebsd.org/D3272 > >> Reviewd by: rpaulo, gnn (previous version) > > > > > > I thought part of this commit message was taken from me as a reviewer, > no? > > Sorry Ermal, my bad. As you only commented and not accepted the review > I thought you don't want to be implied with a reviewed by. > No issue just to be sure that you understood the whole thing there! > > [...] > > >> Added: head/sys/net/altq/altq_codel.c > >> > >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) > >> +++ head/sys/net/altq/altq_codel.c Fri Aug 21 22:02:22 2015 > >> (r287009) > >> @@ -0,0 +1,477 @@ > >> +/* > >> + * CoDel - The Controlled-Delay Active Queue Management algorithm > >> + * > >> + * Copyright (C) 2013 Ermal Luci > > > > > > Can you correct my name? > > > > Sure, I'll commit the fix soon (probably on monday) I'm AFK this weekend. > > No rush :) > I really appreciate your work on Codel. > > Regards, > Luiz > --=20 Ermal