Date: Wed, 05 Aug 2009 01:39:43 +0400 From: Anonymous <swell.k@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/137439: [patch] graphics/gimp-app: ARCH_X86 and ARCH_X86_64 are not defined on amd64 Message-ID: <86eirrjm1s.fsf@gmail.com> Resent-Message-ID: <200908042140.n74LeBso022575@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 137439
>Category: ports
>Synopsis: [patch] graphics/gimp-app: ARCH_X86 and ARCH_X86_64 are not defined on amd64
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Aug 04 21:40:11 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Anonymous
>Release: FreeBSD 8.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD 8.0-BETA2 #0 r196037M: Sun Aug 2 15:30:58 UTC 2009 root@luffy:/usr/obj/usr/src/sys/PHOENIX amd64
>Description:
Some files in gimp rely on ARCH_* macros, e.g.
app/composite/gimp-composite-sse2.h
Looks like I need to use --disable-* options under SIMD in ports/137432
because these optimizations are autodetected without explicit --enable-*.
And they weren't autodetected previously because of this bug.
>How-To-Repeat:
$ make configure ARCH=amd64 ; cp $(make -V WRKSRC)/config.h amd64-config.h
$ make configure ARCH=x86_64; cp $(make -V WRKSRC)/config.h x86_64-config.h
$ diff -up amd64-config.h x86_64-config.h
--- amd64-config.h
+++ x86_64-config.h
@@ -8,10 +8,10 @@
/* #undef ARCH_PPC64 */
/* Define to 1 if you are compiling for ix86. */
-/* #undef ARCH_X86 */
+#define ARCH_X86 1
/* Define to 1 if you are compiling for amd64. */
-/* #undef ARCH_X86_64 */
+#define ARCH_X86_64 1
/* Define to one of `_getb67', `GETB67', `getb67' for Cray-2 and Cray-YMP
systems. This function is required for `alloca.c' support on those systems.
@@ -259,13 +259,13 @@
/* #undef USE_ALTIVEC */
/* Define to 1 if MMX assembly is available. */
-/* #undef USE_MMX */
+#define USE_MMX 1
/* Define to 1 to use POSIX shared memory */
/* #undef USE_POSIX_SHM */
/* Define to 1 if SSE assembly is available. */
-/* #undef USE_SSE */
+#define USE_SSE 1
/* Define to 1 to use SYSV shared memory */
#define USE_SYSV_SHM 1
>Fix:
Attached is a possible fix. It fixes only amd64 case. Not sure about
other architectures.
--- gimp-app.diff begins here ---
Index: graphics/gimp-app/Makefile
===================================================================
RCS file: /home/csup/ports/graphics/gimp-app/Makefile,v
retrieving revision 1.237
diff -u -p -r1.237 Makefile
--- graphics/gimp-app/Makefile 2 Aug 2009 19:34:02 -0000 1.237
+++ graphics/gimp-app/Makefile 4 Aug 2009 21:06:40 -0000
@@ -148,6 +195,7 @@ post-patch:
s|%%GIMP_UI_LIBS%%|${GIMP_UI_LIBS}|' \
${WRKSRC}/plug-ins/pygimp/Makefile.in
@${REINPLACE_CMD} -e 's|"libpng"|"libpng12"|' \
+ -e 's|x86_64|amd64|g' \
${WRKSRC}/configure
post-install:
--- gimp-app.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86eirrjm1s.fsf>