From owner-freebsd-ports-bugs@FreeBSD.ORG  Sun Dec 16 12:33:04 2007
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5DE0616A41B;
	Sun, 16 Dec 2007 12:33:04 +0000 (UTC) (envelope-from pav@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 2B68613C461;
	Sun, 16 Dec 2007 12:33:04 +0000 (UTC) (envelope-from pav@FreeBSD.org)
Received: from freefall.freebsd.org (pav@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lBGCX30a034598;
	Sun, 16 Dec 2007 12:33:03 GMT
	(envelope-from pav@freefall.freebsd.org)
Received: (from pav@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lBGCX33t034576;
	Sun, 16 Dec 2007 12:33:03 GMT (envelope-from pav)
Date: Sun, 16 Dec 2007 12:33:03 GMT
Message-Id: <200712161233.lBGCX33t034576@freefall.freebsd.org>
To: pgollucci@p6m7g8.com, pav@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org,
	pav@FreeBSD.org
From: pav@FreeBSD.org
Cc: 
Subject: Re: ports/118307: www/mod_perl2: [PATCH]: fix
	WITHOUT_APRUTIL_THREADS=yes, minor pkg-list fix, portlint fix
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Dec 2007 12:33:04 -0000

Synopsis: www/mod_perl2: [PATCH]: fix WITHOUT_APRUTIL_THREADS=yes, minor pkg-list fix, portlint fix

State-Changed-From-To: open->feedback
State-Changed-By: pav
State-Changed-When: Sun Dec 16 12:25:42 UTC 2007
State-Changed-Why: 
This patch does not cover the scenario where neither apr.h is present.
Can I suggest something like this instead?

-.if ${APACHE_VERSION} >= 21
+.if exists(${LOCALBASE}/include/apr-1/apr.h)
+APR_H=         ${LOCALBASE}/include/apr-1/apr.h
+.elif exists(${LOCALBASE}/include/apr/apr.h)
+APR_H=         ${LOCALBASE}/include/apr/apr.h
+.endif
+
+.if defined(APR_H)
+APR_HAS_THREADS!=      ${ECHO_CMD} `${GREP} -c 'APR_HAS_THREADS *1' ${APR_H}`
+.else
+APR_HAS_THREADS=       0
+.endif
+
+.if ${APR_HAS_THREADS} == 1
+MAN3+=         APR::ThreadMutex.3
 PLIST_SUB+=    THREADMUTEX=""
 .else
 PLIST_SUB+=    THREADMUTEX="@comment "



Responsible-Changed-From-To: freebsd-ports-bugs->pav
Responsible-Changed-By: pav
Responsible-Changed-When: Sun Dec 16 12:25:42 UTC 2007
Responsible-Changed-Why: 
Track

http://www.freebsd.org/cgi/query-pr.cgi?pr=118307