From owner-svn-src-all@FreeBSD.ORG Fri Apr 27 17:46:24 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1F660106566B; Fri, 27 Apr 2012 17:46:24 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id E4D8D8FC0C; Fri, 27 Apr 2012 17:46:23 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 4F08FB96D; Fri, 27 Apr 2012 13:46:23 -0400 (EDT) From: John Baldwin To: Scott Long Date: Fri, 27 Apr 2012 13:38:37 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p13; KDE/4.5.5; amd64; ; ) References: <201204231304.q3ND43Yg098748@svn.freebsd.org> <201204270745.16844.jhb@freebsd.org> <1335547643.283.YahooMailNeo@web45713.mail.sp1.yahoo.com> In-Reply-To: <1335547643.283.YahooMailNeo@web45713.mail.sp1.yahoo.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201204271338.37236.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 27 Apr 2012 13:46:23 -0400 (EDT) Cc: "svn-src-head@freebsd.org" , Alexander Motin , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" Subject: Re: svn commit: r234603 - head/sys/geom/raid X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2012 17:46:24 -0000 On Friday, April 27, 2012 1:27:23 pm Scott Long wrote: > > ----- Original Message ----- > > From: John Baldwin > > To: Alexander Motin > > Cc: src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src-head@freebsd.org > > Sent: Friday, April 27, 2012 5:45 AM > > Subject: Re: svn commit: r234603 - head/sys/geom/raid > > > > On Monday, April 23, 2012 9:04:03 am Alexander Motin wrote: > >> Author: mav > >> Date: Mon Apr 23 13:04:02 2012 > >> New Revision: 234603 > >> URL: http://svn.freebsd.org/changeset/base/234603 > >> > >> Log: > >> Add names for all primary RAID levels defined by DDF 2.0 specification. > >> > >> Modified: > >> head/sys/geom/raid/g_raid.c > >> head/sys/geom/raid/g_raid.h > >> head/sys/geom/raid/tr_raid1.c > >> head/sys/geom/raid/tr_raid1e.c > > > > We should probably add a separate header to hold DDF constants. graid isn't > > the only place that uses them (e.g. mfi(4) uses it to describe volumes, so > > mfiutil(8) has its own DDF constants as well in mfiutil.h). > > > > -- > > You mean src/sys/dev/ata/ata-raid-ddf.h? Yes. > That said, I trust DDF to be neither universal nor standard, and it's probably a futile micro-optimization to try too hard at this. At the very least, leave MFI alone. Hmm, LSI claims that MFI uses the constant values (but not necessarily the structures from DDF). Certainly the primary RAID type in an mfi(4) volume uses the same constants as both g_raid.h and ata-raid-ddf.h. -- John Baldwin