From owner-svn-src-head@FreeBSD.ORG  Tue Oct 23 16:24:03 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id E4255A9C;
 Tue, 23 Oct 2012 16:24:03 +0000 (UTC)
 (envelope-from yanegomi@gmail.com)
Received: from mail-oa0-f54.google.com (mail-oa0-f54.google.com
 [209.85.219.54])
 by mx1.freebsd.org (Postfix) with ESMTP id 65CEE8FC0A;
 Tue, 23 Oct 2012 16:24:03 +0000 (UTC)
Received: by mail-oa0-f54.google.com with SMTP id n9so4991994oag.13
 for <multiple recipients>; Tue, 23 Oct 2012 09:24:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=1xz5PrQTGIRxXNmN6MXjDE5A1LPORoomKoNQBsQm2kU=;
 b=P5B1sdrTOUByjCZeXYk86mlBs9xwjfFaA/IZoODDaaKSe1kz6Cf6vkYJQmHB62+DAn
 IDE0ZpAUQ2ZxFVeqQyfWjQ5ZQYoPNIwlSBbR+jNG3z65sdwq4/U9b7kJ72UyN7TRVXUt
 kBHqWRXCLNrBX0MxpKlYPG0KlZwkhZKPFADKVQMnOeobCPp85l01qQTvx8JEIiYo4tk2
 h4NZuCPg3r1+eGgXTUNlGtm/vDQHA4zGCy4gmMIXkfQ5Ui5im5OxubRro6xRRmUhdud7
 A6MfhkQapbSBDjDE3WSqOgCMpOHXmGIUh0zt9SfN4opqQTV48sNOSoNZOGoFmT85aSB9
 lJzg==
MIME-Version: 1.0
Received: by 10.182.172.74 with SMTP id ba10mr10479850obc.83.1351009442918;
 Tue, 23 Oct 2012 09:24:02 -0700 (PDT)
Received: by 10.76.143.33 with HTTP; Tue, 23 Oct 2012 09:24:02 -0700 (PDT)
In-Reply-To: <20121023101618.GP70741@FreeBSD.org>
References: <201210230833.q9N8XEas020937@svn.freebsd.org>
 <50865F60.4040409@freebsd.org> <20121023101618.GP70741@FreeBSD.org>
Date: Tue, 23 Oct 2012 09:24:02 -0700
Message-ID: <CAGH67wSzdAnTzmie6et8Jr7hhm5p-WtQFchMUAysMyUcxrU3MA@mail.gmail.com>
Subject: Re: svn commit: r241923 - in head/sys: netinet netipsec
From: Garrett Cooper <yanegomi@gmail.com>
To: Gleb Smirnoff <glebius@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Andre Oppermann <andre@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2012 16:24:04 -0000

On Tue, Oct 23, 2012 at 3:16 AM, Gleb Smirnoff <glebius@freebsd.org> wrote:
> On Tue, Oct 23, 2012 at 11:12:00AM +0200, Andre Oppermann wrote:
> A> On 23.10.2012 10:33, Gleb Smirnoff wrote:
> A> > Author: glebius
> A> > Date: Tue Oct 23 08:33:13 2012
> A> > New Revision: 241923
> A> > URL: http://svn.freebsd.org/changeset/base/241923
> A> >
> A> > Log:
> A> >      Do not reduce ip_len by size of IP header in the ip_input()
> A> >    before passing a packet to protocol input routines.
> A> >      For several protocols this mean that now protocol needs to
> A> >    do subtraction itself, and for another half this means that
> A> >    we do not need to add header length back to the packet.
> A>
> A> Yay! More Mammoth shit getting washed away! ;)
> A>
> A> Please add an entry to UPDATING as the convention of of ip_len
> A> subtraction has been there since forever. That makes it easier
> A> to discover for third parties writing code.
>
> Not sure it worth. Never heard of any loadable protocol outside
> of tree.
>
> Those loadable protocols that we have in tree (carp, divert) do
> not look at ip_len.

    I would follow Andre's advice. People can get clever when
developing under a tight deadline, which can result in interesting
breakage.
Thanks!
-Garrett