From owner-cvs-src@FreeBSD.ORG Sat Apr 3 15:05:40 2004 Return-Path: <owner-cvs-src@FreeBSD.ORG> Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 66ED116A4CE; Sat, 3 Apr 2004 15:05:40 -0800 (PST) Received: from mailbox.univie.ac.at (mailbox.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id B3B8043D2F; Sat, 3 Apr 2004 15:05:39 -0800 (PST) (envelope-from le@FreeBSD.org) Received: from leelou (adslle.cc.univie.ac.at [131.130.102.11]) i33N5SAj1168988; Sun, 4 Apr 2004 01:05:34 +0200 Date: Sun, 4 Apr 2004 01:05:28 +0200 (CEST) From: Lukas Ertl <le@FreeBSD.org> To: Maxime Henrion <mux@FreeBSD.org> In-Reply-To: <200404032256.i33MutpJ094361@repoman.freebsd.org> Message-ID: <20040404010409.X9970@leelou.in.tern> References: <200404032256.i33MutpJ094361@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-DCC-ZID-Univie-Metrics: mailbox 4246; Body=0 Fuz1=0 Fuz2=0 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/growfs growfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/cvs-src> List-Post: <mailto:cvs-src@freebsd.org> List-Help: <mailto:cvs-src-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sat, 03 Apr 2004 23:05:40 -0000 On Sat, 3 Apr 2004, Maxime Henrion wrote: > mux 2004/04/03 14:56:55 PST > > FreeBSD src repository > > Modified files: > sbin/growfs growfs.c > Log: > - Don't abuse caddr_t when what we really want is a void *. > - Use the %jd format and a cast to intmax_t to print an int64_t. > - The return type of getopt() is an int, not a char. Thanks! > This fixes some warnings but there's still much more work to do here. Indeed. Maybe a complete rewrite would be faster. :-) regards, le -- Lukas Ertl http://mailbox.univie.ac.at/~le/ le@FreeBSD.org http://people.freebsd.org/~le/