From owner-cvs-all@FreeBSD.ORG Tue Jun 15 23:11:12 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D69A016A4CE; Tue, 15 Jun 2004 23:11:12 +0000 (GMT) Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id B036B43D5A; Tue, 15 Jun 2004 23:11:12 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by TRANG.nuxi.com (8.12.11/8.12.10) with ESMTP id i5FNB3sN013682; Tue, 15 Jun 2004 16:11:03 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.11/8.12.11/Submit) id i5FNB2vQ013681; Tue, 15 Jun 2004 16:11:02 -0700 (PDT) (envelope-from obrien) Date: Tue, 15 Jun 2004 16:11:01 -0700 From: "David O'Brien" To: Scott Long Message-ID: <20040615231101.GA13516@dragon.nuxi.com> References: <200406132212.i5DMC3b9075832@repoman.freebsd.org> <20040614011012.H1600@newtrinity.zeist.de> <20040614010854.GA98360@dragon.nuxi.com> <40CCFCDF.4040303@freebsd.org> <20040615160107.GT10016@spiff.melthusia.org> <40CF67AA.50600@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40CF67AA.50600@freebsd.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: src-committers@freebsd.org cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: Gordon Tetlow cc: Joseph Dunn Subject: Re: cvs commit: src/sys/dev/sound/pci emu10k1.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jun 2004 23:11:13 -0000 On Tue, Jun 15, 2004 at 03:18:34PM -0600, Scott Long wrote: > It's fine to put an unknown ID into a driver to do local testing and > discovery. It's less acceptable to commit that change to FreeBSD CVS > without knowing what it does and what impact it has. Anyways, this > has been kicked around enough and I believe that David already said > that he will back out the change. I didn't say I plan to back it out -- I said if pushed to I would. Meaning I wont fight much for it. I still think there is definate worth in having the probe message identify the Dell part (so we can find testers). There is no bug report against the driver in 5-CURRENT (which I updated post 5.2.1). This is has gotten into bikeshead teritory, especially since I'm the closest thing we've had to a emu10k1 maintainer in 2-3 years. As other have said: A sound driver probing, attaching, and failing to work is orders of magnitude less an issue than for some other classes of drivers. -- -- David (obrien@FreeBSD.org)