From owner-svn-src-all@FreeBSD.ORG Mon Nov 22 21:20:11 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F131E106566C; Mon, 22 Nov 2010 21:20:11 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id DFEFF8FC12; Mon, 22 Nov 2010 21:20:11 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id oAMLKBGI006295; Mon, 22 Nov 2010 21:20:11 GMT (envelope-from marius@svn.freebsd.org) Received: (from marius@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id oAMLKBRX006292; Mon, 22 Nov 2010 21:20:11 GMT (envelope-from marius@svn.freebsd.org) Message-Id: <201011222120.oAMLKBRX006292@svn.freebsd.org> From: Marius Strobl Date: Mon, 22 Nov 2010 21:20:11 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r215714 - head/sys/dev/mii X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2010 21:20:12 -0000 Author: marius Date: Mon Nov 22 21:20:11 2010 New Revision: 215714 URL: http://svn.freebsd.org/changeset/base/215714 Log: Given that unlike f.e. rgephy(4) these drivers doen't explicitly start an autonegotiation along with manual media selection and also only report flow control status when BMCR_AUTOEN is set (at least with gentbi(4) determining the flow control status results in false-positives when not set), use MIIF_NOMANPAUSE. Modified: head/sys/dev/mii/gentbi.c head/sys/dev/mii/nsgphy.c Modified: head/sys/dev/mii/gentbi.c ============================================================================== --- head/sys/dev/mii/gentbi.c Mon Nov 22 21:13:42 2010 (r215713) +++ head/sys/dev/mii/gentbi.c Mon Nov 22 21:20:11 2010 (r215714) @@ -172,6 +172,8 @@ gentbi_attach(device_t dev) sc->mii_service = gentbi_service; sc->mii_pdata = mii; + sc->mii_flags |= MIIF_NOMANPAUSE; + mii_phy_reset(sc); /* Modified: head/sys/dev/mii/nsgphy.c ============================================================================== --- head/sys/dev/mii/nsgphy.c Mon Nov 22 21:13:42 2010 (r215713) +++ head/sys/dev/mii/nsgphy.c Mon Nov 22 21:20:11 2010 (r215714) @@ -135,6 +135,8 @@ nsgphy_attach(device_t dev) sc->mii_service = nsgphy_service; sc->mii_pdata = mii; + sc->mii_flags |= MIIF_NOMANPAUSE; + mii_phy_reset(sc); /*