Date: Tue, 07 Jul 2015 10:30:30 +0100 From: Vsevolod Stakhov <vsevolod@FreeBSD.org> To: John Marino <marino@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r391493 - head/cad/tkgate Message-ID: <559B9C36.2060300@FreeBSD.org> In-Reply-To: <201507070635.t676Zaqw085725@repo.freebsd.org> References: <201507070635.t676Zaqw085725@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 07/07/2015 07:35, John Marino wrote: > Author: marino Date: Tue Jul 7 06:35:35 2015 New Revision: 391493 > URL: https://svnweb.freebsd.org/changeset/ports/391493 > > Log: cad/tkgate: Unbreak FreeBSD 11, Fix depends on rest > > This was specified on USES: iconv:build,lib > > This is incorrect; the way iconv.mk is written, "build" and "lib" > are mutually exclusive and "build" takes precedence. This means > the library dependency was not registered. > > Moveover, it's failing on FreeBSD 11 and dev-branch of DragonFly > because it uses transliteration. Setting USES=iconv:translit fixes > both issues. > > Approved by: Just fix it Well, from your commit message I can conclude merely that iconv.mk is broken by design. Secondly, I don't understand the meaning of 'translit' option - it is damn confusing name and I cannot see clearly what does it mean in the context of dependencies. Thirdly, isn't it a polite policy to send a notice to a maintainer *before* committing some change to port? I'm not arguing about the change itself, but I do not understand this 'Just fix it policy' when it's absolutely unclear, well at least for me, whether there's a problem with iconv.mk or with the port definition. - -- Vsevolod Stakhov -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJVm5w2AAoJEAdke2eQCBQ3M9oP/2AIw9CH7WVC5/FqUyKTJ+Aq UPPYBbLIY3XXGIK+00CSYaAW0/Etv+xAoODyqMSrpHFyPfRHHlxdFas/BxRvStFf 0/kxMV3XifBHuYhw/+KASytbqpwtr8LAZrthzvN8KrghpCLbESfvxBIy8bXhynMn OIPZ4lNziBmr4sT5ggpz+Ynxd5O3i5ZfaOCVM64IGgSl+PgcZBS8ayPkXzmCUJFd 0otQZK0Vju1lHsV7cshma5iKjDxhmy4Ex+j6L01ZKHXMzVCroLDk9FkmvYyPEbmv frzTKCs9L+0qrCi0WleShXbSqFKDiMfIv8wPJVVT3RxRjVCAhgOmPHxlB/wq3Hp/ yZr5CeLBNfnCqsagg84ok33V4uBTaplErfGFouI+BE3+Ub3Ih4ruiRwjBrgiFLsH kjpkX8ESouOhrhH7nyeqlRlRpTtoSJ1IGg9oR4whZi5hkTSJLIv1BraJkC6R0+3R 86RoucTSEL2fJJAvdRmrfZapjQWKe2tY1t37tOOEaRPse4veG2mT63sJdbiNAup8 dY0Z92XOiigmsqHopBIEDZRgmqS4cSmMFlJk+zA8Hq+Z5HNrjS8M9EyNf+JA5BW4 eb6tyfWKOnJXQiIn9Nknb3aYzi6cGkTHg0QkRSlO40U9UWgFC7dh5qB31oWCPJQh 7EYQ90oRSYm1rsGrrGlg =ShT7 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?559B9C36.2060300>