From owner-cvs-ports@FreeBSD.ORG Fri Aug 25 23:39:01 2006 Return-Path: X-Original-To: cvs-ports@FreeBSD.org Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5741C16A4DE; Fri, 25 Aug 2006 23:39:01 +0000 (UTC) (envelope-from shaun@FreeBSD.org) Received: from dione.picobyte.net (host-212-158-207-124.bulldogdsl.com [212.158.207.124]) by mx1.FreeBSD.org (Postfix) with SMTP id 5C2B243D45; Fri, 25 Aug 2006 23:39:00 +0000 (GMT) (envelope-from shaun@FreeBSD.org) Received: from charon.picobyte.net (charon.picobyte.net [IPv6:2001:4bd0:201e::fe03]) by dione.picobyte.net (Postfix) with ESMTP; Sat, 26 Aug 2006 00:38:58 +0100 (BST) Date: Sat, 26 Aug 2006 00:38:58 +0100 From: Shaun Amott To: Kris Kennaway Message-ID: <20060825233857.GA2548@picobyte.net> References: <200608232057.k7NKvSES014505@repoman.freebsd.org> <20060825201917.GA2949@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20060825201917.GA2949@xor.obsecurity.org> User-Agent: Mutt/1.5.11 (FreeBSD i386) Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/news/inn Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2006 23:39:01 -0000 On Fri, Aug 25, 2006 at 04:19:18PM -0400, Kris Kennaway wrote: > On Wed, Aug 23, 2006 at 08:57:28PM +0000, Shaun Amott wrote: > > shaun 2006-08-23 20:57:28 UTC > > > > FreeBSD ports repository > > > > Modified files: > > news/inn Makefile > > Log: > > Amend hostname check to succeed if /bin/hostname fails. > > Another work-around for those pesky amd64 machines. > > This isn't going to work as you intend since the IGNORE check is run > on pointyhat to decide whether to build the ports, which naturally > succeeds. Well, maybe this wasn't the right approach, but I did intend the check to affect pointyhat builds. > The real issue here is not 'amd64 machines' but ports built in a jail > without access to a DNS server (this will become the default in the > near future). I know - I wasn't suggesting it was a problem with amd64 as a platform - it's just a coincidence that the affected machines have all been amd64. The port checks that the machine/jail's hostname is valid (i.e. host.domain), not just resolvable, and the work-around seems to work in both cases I have seen. > Why does this port need to look up its hostname during build? If it > is hard-coding the result in the package, then it is clearly wrong. > On the other hand if it not hard-coding the result then it begs the > question of why do it at all. The look-up is performed as part of a syntax check on the default config file. The hostname is inserted into the file, which, as you you say, is wrong. I have come up with an alternative solution to this issue, which I shall apply to the inn ports shortly. Shaun -- Shaun Amott [ PGP: 0x6B387A9A ] Scientia Est Potentia.