From owner-freebsd-bugs@FreeBSD.ORG  Tue Apr 20 17:40:03 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 996091065676
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 20 Apr 2010 17:40:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 887648FC2C
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 20 Apr 2010 17:40:03 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o3KHe3lb001121
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 20 Apr 2010 17:40:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o3KHe3MX001120;
	Tue, 20 Apr 2010 17:40:03 GMT (envelope-from gnats)
Date: Tue, 20 Apr 2010 17:40:03 GMT
Message-Id: <201004201740.o3KHe3MX001120@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Mateusz Guzik <mjguzik@gmail.com>
Cc: 
Subject: Re: kern/145865: kernel memory leak with disabled devd and 
	hw.bus.devctl_disable=1
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Mateusz Guzik <mjguzik@gmail.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2010 17:40:03 -0000

The following reply was made to PR kern/145865; it has been noted by GNATS.

From: Mateusz Guzik <mjguzik@gmail.com>
To: bug-followup@FreeBSD.org, littlesavage@orionet.ru
Cc:  
Subject: Re: kern/145865: kernel memory leak with disabled devd and 
	hw.bus.devctl_disable=1
Date: Tue, 20 Apr 2010 19:33:28 +0200

 devctl_queue_length is checked twice.
 
 1)
  if (devctl_queue_length == 0)
                 return;
 
 So we leak message passed by the caller.
 
 2)
 mtx_lock(&devsoftc.mtx);
  if (devctl_queue_length == 0) {
                 free(n1->dei_data, M_BUS);
                 free(n1, M_BUS);
                 return;
 }
 
 So we can return with lock held where we shouldn't (or I'm
 misinterpreting something).
 
 How about this patch then:
 http://student.agh.edu.pl/~mjguzik/subr_bus.diff
 
 --
 Mateusz Guzik