From owner-svn-src-head@freebsd.org Thu Jul 26 15:44:22 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2D89E1052FDE; Thu, 26 Jul 2018 15:44:22 +0000 (UTC) (envelope-from daichigoto@icloud.com) Received: from mr22p34im-asmtp001.me.com (mr22p34im-asmtp001.me.com [17.111.211.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C46D895496; Thu, 26 Jul 2018 15:44:21 +0000 (UTC) (envelope-from daichigoto@icloud.com) Received: from process-dkim-sign-daemon.mr22p34im-asmtp001.me.com by mr22p34im-asmtp001.me.com (Oracle Communications Messaging Server 8.0.1.2.20170607 64bit (built Jun 7 2017)) id <0PCH00500A12TO00@mr22p34im-asmtp001.me.com>; Thu, 26 Jul 2018 14:44:15 +0000 (GMT) Received: from icloud.com ([127.0.0.1]) by mr22p34im-asmtp001.me.com (Oracle Communications Messaging Server 8.0.1.2.20170607 64bit (built Jun 7 2017)) with ESMTPSA id <0PCH0072UA88UZ00@mr22p34im-asmtp001.me.com>; Thu, 26 Jul 2018 14:44:14 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-26_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1011 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1807260154 Content-type: text/plain; charset=utf-8 MIME-version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: svn commit: r336737 - head/usr.bin/top From: =?utf-8?B?5b6M6Jek5aSn5Zyw?= In-reply-to: <201807261422.w6QEMUwH046070@pdx.rh.CN85.dnsmgr.net> Date: Thu, 26 Jul 2018 23:44:12 +0900 Cc: Daichi GOTO , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-transfer-encoding: quoted-printable Message-id: <32C0FF83-9BE2-4950-9FFD-1FA10463C535@icloud.com> References: <201807261422.w6QEMUwH046070@pdx.rh.CN85.dnsmgr.net> To: rgrimes@freebsd.org X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 15:44:22 -0000 I see. thank you for the advice! > 2018/07/26 23:22=E3=80=81Rodney W. Grimes = =E3=81=AE=E3=83=A1=E3=83=BC=E3=83=AB: >=20 >> Author: daichi >> Date: Thu Jul 26 13:53:22 2018 >> New Revision: 336737 >> URL: https://svnweb.freebsd.org/changeset/base/336737 >>=20 >> Log: >> top(1): forgot in r336160 >=20 > It is helpful to say what was forgot in the commit message as when > you are reading a svn log output you do not have the diff to show > you what it was that has been forgot. >=20 > Better message would of been: > Remove utf8strvisx prototype, forgotten in r336160 >=20 >=20 > Thanks, > Rod >>=20 >> Approved by: gnn (mentor) >> Differential Revision: https://reviews.freebsd.org/D16452 >>=20 >> Modified: >> head/usr.bin/top/utils.h >>=20 >> Modified: head/usr.bin/top/utils.h >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/usr.bin/top/utils.h Thu Jul 26 13:33:10 2018 = (r336736) >> +++ head/usr.bin/top/utils.h Thu Jul 26 13:53:22 2018 = (r336737) >> @@ -22,5 +22,4 @@ const char *format_time(long); >> char *format_k(int64_t); >> int string_index(const char *string, const char * const *array); >> int find_pid(pid_t pid); >> -int utf8strvisx(char *, const char *, size_t); >>=20 >>=20 >>=20 >=20 > --=20 > Rod Grimes = rgrimes@freebsd.org