From owner-svn-src-all@FreeBSD.ORG Fri Feb 11 19:11:05 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E02301065670; Fri, 11 Feb 2011 19:11:05 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id 6EBB18FC12; Fri, 11 Feb 2011 19:11:05 +0000 (UTC) Received: by gyc15 with SMTP id 15so1232589gyc.13 for ; Fri, 11 Feb 2011 11:11:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=libFk7NDpWno//HFRZAyJHllCLPN/8BYUDReAAtN8tc=; b=TWgLaBHHA7k6gwrrJRNwk2X+qLmC6hksQeopIGlZTSA0Xrf0XLlrD5PtkTYidV9zTV EDRzEF0uAN/IRZYEtXrjx4La4qZKDaDCu/M9aHywpYm+AAOJYplvYWoTisRpVBOkERU5 jYQJezPrWACtnpm42Bj58FLHGzWSRloTQZGMw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=ffbopb+aQQVlyUIYIyAf5Rfs/wnenkj8F83w4l0LLVlRilykBQCSjhzExpfaiweKxc SlUGGMB1Y/SeIZENQnTpReNGS21kLHMTyMKI8/cN4u2UZsDgHAg01jgscSKkZjczvBlV 6H/b8g06sVj+qAQLvWQDsWopdmUQsDdRNgjE4= MIME-Version: 1.0 Received: by 10.150.203.13 with SMTP id a13mr916430ybg.54.1297450076060; Fri, 11 Feb 2011 10:47:56 -0800 (PST) Received: by 10.147.167.5 with HTTP; Fri, 11 Feb 2011 10:47:56 -0800 (PST) In-Reply-To: <20110211184043.T80258@maildrop.int.zabbadoz.net> References: <201102111718.p1BHIg8t068172@svn.freebsd.org> <4D558236.7000409@FreeBSD.org> <20110211184043.T80258@maildrop.int.zabbadoz.net> Date: Fri, 11 Feb 2011 10:47:56 -0800 Message-ID: From: Jack Vogel To: "Bjoern A. Zeeb" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Jack F Vogel , svn-src-head@freebsd.org, svn-src-all@freebsd.org, Doug Barton , src-committers@freebsd.org Subject: Re: svn commit: r218581 - head/sys/dev/e1000 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Feb 2011 19:11:06 -0000 Ya, I just saw that, I think I will Bjoern, only because its gonna be a problem the next time I check in shared code, I don't really even own the stuff, when my internal build runs it just filters the defines in the stuff according to my needs, but doesn't directly change anything. I was gonna send email around midnight last night and say I saw the breakage, but I couldn't fix it til this morning, you had good intentions anyway :) Jack On Fri, Feb 11, 2011 at 10:42 AM, Bjoern A. Zeeb wrote: > On Fri, 11 Feb 2011, Doug Barton wrote: > > On 02/11/2011 09:18, Jack F Vogel wrote: >> >>> Modified: head/sys/dev/e1000/e1000_mac.h >>> >>> ============================================================================== >>> --- head/sys/dev/e1000/e1000_mac.h Fri Feb 11 16:14:16 2011 >>> (r218580) >>> +++ head/sys/dev/e1000/e1000_mac.h Fri Feb 11 17:18:42 2011 >>> (r218581) >>> @@ -70,6 +70,7 @@ s32 e1000_led_on_generic(struct e1000_h >>> s32 e1000_led_off_generic(struct e1000_hw *hw); >>> void e1000_update_mc_addr_list_generic(struct e1000_hw *hw, >>> u8 *mc_addr_list, u32 >>> mc_addr_count); >>> +s32 e1000_set_default_fc_generic(struct e1000_hw *hw); >>> >> >> This is a redundant declaration, it's already defined in _api.h. >> Commenting this out allows the build to succeed, and if you receive this >> message it seems to be working fine. :) >> > > Yeah, I put it into _api.h this morning to unbreak the build. Jack, > you may want to revert parts of my commit and adjust to your local > trees (mine had a style bug anyway;) > > That was the commit: > http://svn.freebsd.org/changeset/base/218548 > > /bz > > -- > Bjoern A. Zeeb You have to have visions! > Stop bit received. Insert coin for new address family. >