From owner-svn-src-head@freebsd.org Sat Jan 12 21:02:59 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01BB0149EE04; Sat, 12 Jan 2019 21:02:59 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8AF146FFE9; Sat, 12 Jan 2019 21:02:58 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f53.google.com with SMTP id b23so14861894ios.10; Sat, 12 Jan 2019 13:02:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=J7DX5OHFzlAbCnKrD3T1JVpOUGNvCEXqPpfUeQQpLeI=; b=P2hS2ry30Li0lkAVQ4t9hAD+X/9okllkfdFSz8M+PSB0rry7UaAo/mNKQ0zKuohEel e7R6rd4NsjB2K+2EKZFJ7jILBRWObbi7cvT5UI1jPEFpolUY5HcqivnMkERSPwb9nKhM AkynkaqEiYK+BunOlv6bWXeI/KapJkX3CY4hwbTA9AsxAwqwIFVPHBvX5gEFICxjZMkd AiyGzlx1e72RSfuhhczavRIytGccVBlkqb0QhdVLap9ZxSgyDCtMUGvtKl4rTaccujkj szvrmgtuaTWPCIoi0bNYXNb9bAX6/SlRnn4bbmlfmIiirYXYxjsz8DhA2cmtBgaD9+NX JSsA== X-Gm-Message-State: AJcUukedEKPQGesfFC3FLfSTEgBGPQCW4Y9gI/fQdqdnDGybQKMgGv4L I6VMTt1rsEW2gyFvwa4pzF6Q39/P X-Google-Smtp-Source: ALg8bN6y7qvw5WBavxUIj8U9D477NzZAkbRfZVGQMT1LAw2XCPFDqz9pRi26KHLlICOaxdQitaB52w== X-Received: by 2002:a6b:6b02:: with SMTP id g2mr12264112ioc.18.1547326528827; Sat, 12 Jan 2019 12:55:28 -0800 (PST) Received: from mail-it1-f170.google.com (mail-it1-f170.google.com. [209.85.166.170]) by smtp.gmail.com with ESMTPSA id e5sm35985533ios.50.2019.01.12.12.55.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Jan 2019 12:55:28 -0800 (PST) Received: by mail-it1-f170.google.com with SMTP id x124so4948145itd.1; Sat, 12 Jan 2019 12:55:28 -0800 (PST) X-Received: by 2002:a02:a791:: with SMTP id e17mr14870685jaj.104.1547326528532; Sat, 12 Jan 2019 12:55:28 -0800 (PST) MIME-Version: 1.0 References: <201901122041.x0CKfvUi057392@repo.freebsd.org> In-Reply-To: <201901122041.x0CKfvUi057392@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sat, 12 Jan 2019 12:55:17 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r342973 - head/sys/kern To: Andrew Turner Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 8AF146FFE9 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.973,0]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jan 2019 21:02:59 -0000 Maybe bump FreeBSD_version in sys/param.h since these seem to be asserting KBI and have now been changed. Best, Conrad On Sat, Jan 12, 2019 at 12:42 PM Andrew Turner wrote: > > Author: andrew > Date: Sat Jan 12 20:41:57 2019 > New Revision: 342973 > URL: https://svnweb.freebsd.org/changeset/base/342973 > > Log: > Fix the check for the offset of td_frame and td_emuldata in struct thread. > > Pointy hat: andrew > Sponsored by: DARPA, AFRL > > Modified: > head/sys/kern/kern_thread.c > > Modified: head/sys/kern/kern_thread.c > ============================================================================== > --- head/sys/kern/kern_thread.c Sat Jan 12 17:56:23 2019 (r342972) > +++ head/sys/kern/kern_thread.c Sat Jan 12 20:41:57 2019 (r342973) > @@ -102,9 +102,9 @@ _Static_assert(offsetof(struct thread, td_flags) == 0x > "struct thread KBI td_flags"); > _Static_assert(offsetof(struct thread, td_pflags) == 0xa0, > "struct thread KBI td_pflags"); > -_Static_assert(offsetof(struct thread, td_frame) == 0x2e8, > +_Static_assert(offsetof(struct thread, td_frame) == 0x2ec, > "struct thread KBI td_frame"); > -_Static_assert(offsetof(struct thread, td_emuldata) == 0x334, > +_Static_assert(offsetof(struct thread, td_emuldata) == 0x338, > "struct thread KBI td_emuldata"); > _Static_assert(offsetof(struct proc, p_flag) == 0x68, > "struct proc KBI p_flag"); >