From owner-svn-src-all@freebsd.org Tue Dec 13 01:56:29 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 586A5C74428; Tue, 13 Dec 2016 01:56:29 +0000 (UTC) (envelope-from dteske@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2820C1973; Tue, 13 Dec 2016 01:56:29 +0000 (UTC) (envelope-from dteske@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id uBD1uS1F050588; Tue, 13 Dec 2016 01:56:28 GMT (envelope-from dteske@FreeBSD.org) Received: (from dteske@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id uBD1uSh8050587; Tue, 13 Dec 2016 01:56:28 GMT (envelope-from dteske@FreeBSD.org) Message-Id: <201612130156.uBD1uSh8050587@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: dteske set sender to dteske@FreeBSD.org using -f From: Devin Teske Date: Tue, 13 Dec 2016 01:56:28 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r309972 - head/usr.sbin/bsdinstall/scripts X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2016 01:56:29 -0000 Author: dteske Date: Tue Dec 13 01:56:28 2016 New Revision: 309972 URL: https://svnweb.freebsd.org/changeset/base/309972 Log: If the first ping succeeded, why on Earth should we ping it again? Modified: head/usr.sbin/bsdinstall/scripts/wlanconfig Modified: head/usr.sbin/bsdinstall/scripts/wlanconfig ============================================================================== --- head/usr.sbin/bsdinstall/scripts/wlanconfig Tue Dec 13 01:54:44 2016 (r309971) +++ head/usr.sbin/bsdinstall/scripts/wlanconfig Tue Dec 13 01:56:28 2016 (r309972) @@ -170,19 +170,19 @@ if ! wpa_cli ping > /dev/null 2>&1; then wpa_supplicant -B -i $1 -c "$BSDINSTALL_TMPETC/wpa_supplicant.conf") || $DIALOG --backtitle "$DIALOG_BACKTITLE" --title "$msg_error" --msgbox \ "Could not start wpa_supplicant!" 0 0; exit 1 || exit 1 -fi -# See if we succeeded -wpa_cli ping > /dev/null 2>&1 -if [ $? -ne 0 -a ! "$BSDINSTALL_CONFIGCURRENT" ]; then - $DIALOG \ - --title "$msg_error" \ - --backtitle "$DIALOG_BACKTITLE" \ - --msgbox "Wireless cannot be configured without making changes to the local system!" \ - 0 0 - exit 1 + wpa_cli ping > /dev/null 2>&1 + if [ $? -ne 0 -a ! "$BSDINSTALL_CONFIGCURRENT" ]; then + $DIALOG \ + --title "$msg_error" \ + --backtitle "$DIALOG_BACKTITLE" \ + --msgbox "Wireless cannot be configured without making changes to the local system!" \ + 0 0 + exit 1 + fi fi + # # There is no way to check country/regdomain without (possible) # interface state modification