Date: Fri, 30 Jun 2006 14:17:53 +0400 From: Sergey Matveychuk <sem@FreeBSD.org> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: Mark Linimon <linimon@lonesome.com>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, Mark Linimon <linimon@FreeBSD.org>, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.port.mk Message-ID: <44A4FA51.1030402@FreeBSD.org> In-Reply-To: <44A4382A.6080401@marcuscom.com> References: <200606262339.k5QNd9pa047918@repoman.freebsd.org> <44A1ACF5.4000501@FreeBSD.org> <20060627223848.GA26790@soaustin.net> <1151461120.81245.5.camel@shumai.marcuscom.com> <44A38295.8020506@FreeBSD.org> <1151587983.87977.1.camel@shumai.marcuscom.com> <44A427A2.30006@FreeBSD.org> <44A4382A.6080401@marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Joe Marcus Clarke wrote:
> Sergey Matveychuk wrote:
>>> Joe Marcus Clarke wrote:
>>>> On Thu, 2006-06-29 at 11:34 +0400, Sergey Matveychuk wrote:
>>>>> Joe Marcus Clarke wrote:
>>>>>> This, of course, would not cause the error. As I said to Mark in a
>>>>>> follow-up email, it may very well be time to retire DEPENDS, but the
>>>>>> patch that was committed did not successfully do that and maintain the
>>>>>> buildability of the tree.
>>>>>>
>>>>> Using FORCE_PKG_REGISTER inside bsd.port.mk is is hacky and wrong.
>>>>> I think we can make up a better solution for the problem with kdehier.
>>>>> I'll think for it on this weekend.
>>>> There are other solutions. See gnomehier, for example. It's not just
>>>> kdehier, though. Anything that uses DEPENDS would have been broken.
>>>>
>>> A little number really:
>>> % find . -name Makefile -exec grep ^DEPENDS= {} /dev/null \;
>>> ./audio/klira/Makefile:DEPENDS= ${PORTSDIR}/misc/kdehier
>>> ./lang/pm3-forms/Makefile:DEPENDS= ${PORTSDIR}/lang/pm3-base:build
>>> ./www/caudium12/Makefile:DEPENDS= ${PORTSDIR}/lang/pexts/
>>> ./x11/kdelibs3/Makefile:DEPENDS= ${PORTSDIR}/misc/kdehier
>>>
>>> pm3-forms does no harm (just build target).
>>> DEPENDS in it and in caudium12 can be changed with
>>> BUILD_DEPENDS/RUN_DEPENDS easily.
>>>
>>> May be it's time to get rid of obsoleted DEPENDS?
>
> I have no objection, but the patch would need to be more complete than
> the previous one.
Sure. It will.
--
Dixi.
Sem.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44A4FA51.1030402>