From owner-svn-src-head@freebsd.org Wed Mar 28 16:14:28 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CE21FF6A976; Wed, 28 Mar 2018 16:14:28 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 786D173DB0; Wed, 28 Mar 2018 16:14:28 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id E8C8510AC13; Wed, 28 Mar 2018 12:14:19 -0400 (EDT) From: John Baldwin To: Jeff Roberson Cc: Li-Wen Hsu , "O. Hartmann" , Jeff Roberson , pho@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r331606 - in head/sys: amd64/include i386/include x86/x86 x86/xen Date: Wed, 28 Mar 2018 09:08:19 -0700 Message-ID: <2531747.pQxc7AOloZ@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: References: <201803270337.w2R3b4iv035285@repo.freebsd.org> <20180327101309.GA75720@freefall.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Wed, 28 Mar 2018 12:14:20 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 16:14:29 -0000 On Tuesday, March 27, 2018 11:07:22 AM Jeff Roberson wrote: > On Tue, 27 Mar 2018, Li-Wen Hsu wrote: > > > On Mon, Mar 26, 2018 at 20:35:12 -1000, Jeff Roberson wrote: > >> The patch has been on my branch for weeks and has been tested by a half > >> dozen people. I'm sorry it does not work for you. If you reverted 331605 > >> the change that followed should not have built properly. Did you build > >> cleanly? Can you share your kernel config? > >> > >> I tried with and without EARLY_AP_STARTUP and with and without NUMA. I'm > >> not having any trouble booting. Did you make cleandepend && make depend? > > > > It also hangs in our testing system: > > > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/6817/console > > https://ci.freebsd.org/job/FreeBSD-head-i386-test/1000/console > > > > It is built cleanly and uses unmodified GENERIC config. > > > > The artifacts used are available here: > > > > https://artifact.ci.freebsd.org/snapshot/head/r331606/amd64/amd64/ > > https://artifact.ci.freebsd.org/snapshot/head/r331606/i386/i386/ > > > > Hope these information help. > > Could someone who was experiencing the hang try the enclosed patch? I can > only verify that it continues to boot for me but I believe this fixes the > bug on other systems. > > I believe the issue was that cpuset_domain[0] was initialized too late on > some systems. It depended on what kind of hardware was present and which > sysinit with SI_ORDER_ANY ran first. Hmm, does this work if you don't use EARLY_AP_STARTUP? I think all_cpus isn't set yet (or only contains the BSP) when cpuset_thread0 is run if you don't have EARLY_AP_STARTUP (and EARLY_AP_STARTUP is only supported on x86 currently) -- John Baldwin