From owner-svn-src-all@freebsd.org Thu Jul 11 08:38:01 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2994215CB99B; Thu, 11 Jul 2019 08:38:01 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9EDE76CD39; Thu, 11 Jul 2019 08:38:00 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x42d.google.com with SMTP id j2so2413676pfe.6; Thu, 11 Jul 2019 01:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=3UBZ/7kHrc8s5iB6X/AAff4ovemHn3/8xhPdX8yVFCc=; b=YlfYSiArDe50XgI/QwABeJlNLmIYfho/EB0nsvg1wLWJrKsURLdiYWq5gACT7CV24j M/gGLbMh2N1Tt89IDzQfULny8TRfXa+cjQM49DO/60Ms+PJFrLv98mla6pgoyai0Wpul WtqTRkioMPTCPwP5apY1bQBTBjw2fl8Q4mTAHjnn1JIsOXVRIs7DnqGf7oG7PpvYxKPo pJSstEoni6Vtq+cU4g31HRDHj9k19ThXlTjAeJo2CXbRmOCp4s6rxp7t8KGAh/ayDoW1 yHRfaPw+tW93guRVOnGYo3pYhgMGENvVU9CP6plnUnjN27p0Cj7w+zw1Nx6v8FUoFbUE Yibg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=3UBZ/7kHrc8s5iB6X/AAff4ovemHn3/8xhPdX8yVFCc=; b=St7BZspXw7QgChSNgNr56JCwx0N4ZX6dH8SeyHUyC9QGwC/psjkvJuyGdhguPgsLDD GOqFD1IKDwoYgnGKWUdeArYXufEGMHPVMS7V2zlhp17VXrru2KzHOJbjhLqg1Z6eA//C jSiy8RPKhXti8ly88lV3doZGcq3oinG0FpNYrZ8N531+aaWPto6nmpC9sLNXBZ+Q7hzF aEjjnpnLfq92GVEdLKg1BSLmwQcjMidBJvHj74DWFFkOvjXXncDGwQxmfLKo1GYOMuoY MDmvi1Axu4r+1zyPKTVvDFxywRpNt2YUn1zAvlKkKAl2yUX0rW9Cov3naUnTfEqAcL1I EDaA== X-Gm-Message-State: APjAAAUId/0B+DpibEdAn5WQzbhAIACvsS+SrzV2isWARa+0ILgVBnLb QMHJv3JjuWNV2jnjHBze/lGG5I61bXo= X-Google-Smtp-Source: APXvYqyAjnYIhABMpm/GB7VFZbAFG8XlyM/5M2/oM05UtYDz0lvtOc6AdP4GWsjOAcEj1+9vIsvQ3Q== X-Received: by 2002:a65:62ca:: with SMTP id m10mr3122365pgv.57.1562834278293; Thu, 11 Jul 2019 01:37:58 -0700 (PDT) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id 131sm6756956pfx.57.2019.07.11.01.37.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jul 2019 01:37:57 -0700 (PDT) From: Enji Cooper Message-Id: <6AC34953-52FC-48FC-B83F-CFFB6A48EC84@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: svn commit: r349907 - head/sys/netinet/tcp_stacks Date: Thu, 11 Jul 2019 01:37:56 -0700 In-Reply-To: <201907110438.x6B4cXX1054795@repo.freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Randall Stewart References: <201907110438.x6B4cXX1054795@repo.freebsd.org> X-Mailer: Apple Mail (2.3445.104.11) X-Rspamd-Queue-Id: 9EDE76CD39 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.93 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.93)[-0.933,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jul 2019 08:38:01 -0000 > On Jul 10, 2019, at 9:38 PM, Randall Stewart wrote: >=20 > Author: rrs > Date: Thu Jul 11 04:38:33 2019 > New Revision: 349907 > URL: https://svnweb.freebsd.org/changeset/base/349907 >=20 > Log: > Update copyright per JBH's suggestions.. thanks. >=20 > Modified: > head/sys/netinet/tcp_stacks/rack.c >=20 > Modified: head/sys/netinet/tcp_stacks/rack.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/netinet/tcp_stacks/rack.c Thu Jul 11 03:29:25 2019 = (r349906) > +++ head/sys/netinet/tcp_stacks/rack.c Thu Jul 11 04:38:33 2019 = (r349907) > @@ -1,5 +1,5 @@ > /*- > - * Copyright (c) 2016 > + * Copyright (c) 2016-2019 > * Netflix Inc. All rights reserved. > * > * Redistribution and use in source and binary forms, with or without > @@ -8537,10 +8537,10 @@ out: > * retransmit. In persist state, just set snd_max. > */ > if (error =3D=3D 0) { > -/* if (TCPS_HAVEESTABLISHED(tp->t_state) && > + if (TCPS_HAVEESTABLISHED(tp->t_state) && > (tp->t_flags & TF_SACK_PERMIT) && > tp->rcv_numsacks > 0) > - tcp_clean_dsack_blocks(tp);*/ > + tcp_clean_dsack_blocks(tp); Removing this commented out code unfortunately broke the build: = https://ci.freebsd.org/job/FreeBSD-head-amd64-LINT/12934/console = . Thanks, -Enji