From owner-freebsd-ports Mon Dec 8 22:47:50 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id WAA05337 for ports-outgoing; Mon, 8 Dec 1997 22:47:50 -0800 (PST) (envelope-from owner-freebsd-ports) Received: from gratis.grondar.za (gratis.grondar.za [196.7.18.133]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id WAA05330 for ; Mon, 8 Dec 1997 22:47:45 -0800 (PST) (envelope-from mark@greenpeace.grondar.za) Received: from greenpeace.grondar.za (IL68oCzaSnCdIEt6KNp762pwD3v9dnvy@greenpeace.grondar.za [196.7.18.132]) by gratis.grondar.za (8.8.7/8.8.8) with ESMTP id IAA06410; Tue, 9 Dec 1997 08:47:59 +0200 (SAT) (envelope-from mark@greenpeace.grondar.za) Received: from greenpeace.grondar.za (MufjXUlo+FAB0aBcSaDWL0ONHQD5yx16@localhost [127.0.0.1]) by greenpeace.grondar.za (8.8.8/8.8.8) with ESMTP id IAA13796; Tue, 9 Dec 1997 08:51:42 +0200 (SAST) (envelope-from mark@greenpeace.grondar.za) Message-Id: <199712090651.IAA13796@greenpeace.grondar.za> X-Mailer: exmh version 2.0zeta 7/24/97 To: Sheldon Hearn cc: freebsd-ports@FreeBSD.ORG Subject: Re: Possible problem with ftpd 6.00 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 09 Dec 1997 08:51:37 +0200 From: Mark Murray Sender: owner-freebsd-ports@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Sheldon Hearn wrote: > [A] Ownership > > It currently installs aftpd into ${PREFIX}/libexec owned by bin:bin . > The ownership doesn't seem to matter much because: > > 1) it's called from inetd and run as root > > 2) it needs root priveledge to chroot into /home/ftp > > 3) it does set{gu}id to ftp:operator as soon as the chroot is done > > Should I be pedantic and install with different ownership? No. > [B] Compiled defaults > > As per mjr's recommendation in the README file, I've hardcoded the > desired ftp chroot dir into the binary. It can still be overrided using > command line options (mjr's concerns about passing arguments from inetd > don't apply to FreeBSD's inetd). > > Is /home/ftp a religiously sound default? Yuk. It should really use user ftp's home dir from /etc/passwd. > Also, is it acceptable for me to use UID 14 and GID 5 for ftp:operator > or should I be getting a script to dig those numbers out of /etc/* at > the configure stage? No. The script to discover what they actually are is necessary. > [C] Source patch review > > A small change to the source was required for building on 2.2-RELENG > (untested on -CURRENT). From my understanding of the philosophy behind > C, I've done the right thing. but I have no programming experience to > validate my whim. > > What is the best way for me to have the change I've made to the source > code reviewed prior to port submission? You just did it. :-). Ask on this list. M -- Mark Murray Join the anti-SPAM movement: http://www.cauce.org