From owner-svn-src-head@FreeBSD.ORG  Sun Apr 20 18:21:06 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 68F9BC40;
 Sun, 20 Apr 2014 18:21:06 +0000 (UTC)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5613816A6;
 Sun, 20 Apr 2014 18:21:06 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s3KIL6OS072037;
 Sun, 20 Apr 2014 18:21:06 GMT (envelope-from ian@svn.freebsd.org)
Received: (from ian@localhost)
 by svn.freebsd.org (8.14.8/8.14.8/Submit) id s3KIL6UW072036;
 Sun, 20 Apr 2014 18:21:06 GMT (envelope-from ian@svn.freebsd.org)
Message-Id: <201404201821.s3KIL6UW072036@svn.freebsd.org>
From: Ian Lepore <ian@FreeBSD.org>
Date: Sun, 20 Apr 2014 18:21:06 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r264702 - head/sys/arm/arm
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Apr 2014 18:21:06 -0000

Author: ian
Date: Sun Apr 20 18:21:05 2014
New Revision: 264702
URL: http://svnweb.freebsd.org/changeset/base/264702

Log:
  Remove uncessary cache and TLB maintenance ops.
  
   - These were needed on armv4/5 (VIVT cache), not needed on armv6.
   - The wbinv_all call can't be used on SMP systems; cache operations by
     set/way are not broadcast to other cores.
   - The TLB maintenance operations needed for pmap_growkernel() happen in
     pmap_grow_l2_bucket(), so there's no need to flush all TLB entries at
     the end.
   - There may not be any need for the TLB flush at the beginning of
     pmap_release(), but it's left in for now pending more investigation.
  
  Pointed out by:	   Svatopluk Kraus <onwahe@gmail.com>
  Discussed with:	   cognet@

Modified:
  head/sys/arm/arm/pmap-v6.c

Modified: head/sys/arm/arm/pmap-v6.c
==============================================================================
--- head/sys/arm/arm/pmap-v6.c	Sun Apr 20 18:15:23 2014	(r264701)
+++ head/sys/arm/arm/pmap-v6.c	Sun Apr 20 18:21:05 2014	(r264702)
@@ -1988,8 +1988,6 @@ pmap_release(pmap_t pmap)
 {
 	struct pcb *pcb;
 
-	cpu_idcache_wbinv_all();
-	cpu_l2cache_wbinv_all();
 	cpu_tlb_flushID();
 	cpu_cpwait();
 	if (vector_page < KERNBASE) {
@@ -2175,14 +2173,6 @@ pmap_growkernel(vm_offset_t addr)
 	for (; pmap_curmaxkvaddr < addr; pmap_curmaxkvaddr += L1_S_SIZE)
 		pmap_grow_l2_bucket(kpmap, pmap_curmaxkvaddr);
 
-	/*
-	 * flush out the cache, expensive but growkernel will happen so
-	 * rarely
-	 */
-	cpu_dcache_wbinv_all();
-	cpu_l2cache_wbinv_all();
-	cpu_tlb_flushD();
-	cpu_cpwait();
 	kernel_vm_end = pmap_curmaxkvaddr;
 }