From owner-freebsd-hackers@FreeBSD.ORG  Tue Jan 13 15:48:25 2015
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4DBF02C6;
 Tue, 13 Jan 2015 15:48:25 +0000 (UTC)
Received: from smtp.vangyzen.net (hotblack.vangyzen.net
 [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f])
 by mx1.freebsd.org (Postfix) with ESMTP id 2F1B998;
 Tue, 13 Jan 2015 15:48:25 +0000 (UTC)
Received: from marvin.lab.vangyzen.net (c-24-125-214-90.hsd1.va.comcast.net
 [24.125.214.90])
 by smtp.vangyzen.net (Postfix) with ESMTPSA id BE6CA56467;
 Tue, 13 Jan 2015 09:48:17 -0600 (CST)
Message-ID: <54B53E40.1030903@vangyzen.net>
Date: Tue, 13 Jan 2015 10:48:16 -0500
From: Eric van Gyzen <eric@vangyzen.net>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.0
MIME-Version: 1.0
To: Lars Engels <lars.engels@0x20.net>, 
 Allan Jude <allanjude@freebsd.org>
Subject: Re: [PATCH] Display progress during getmemsize() so the kernel doesn't
 look like it hanged
References: <D0D89A8E.129518%rpokala@panasas.com>
 <54B35B36.4040504@freebsd.org> <20150113091122.GK67556@e-new.0x20.net>
In-Reply-To: <20150113091122.GK67556@e-new.0x20.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: freebsd-hackers@freebsd.org
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Jan 2015 15:48:25 -0000

On 01/13/2015 04:11, Lars Engels wrote:
> On Mon, Jan 12, 2015 at 12:27:18AM -0500, Allan Jude wrote:
>> Is this feature still useful with memtest.tests=0?
> This feature is useful for everyone who has it set to 1, if they know
> about it or not. So it's a very useful feature.

Agreed.

Comments on the patch:

The patch will divide by zero when PAGE_SIZE > 1 MiB.  Maybe remove
PAGES_PER_MB, and just use PAGES_PER_GB.  Make it const, too.

The "total" line is mostly redundant with the later messages regarding
"real memory" and "avail memory".  I suggest removing it.

Eric