From owner-cvs-all  Wed Feb 20  6:54:27 2002
Delivered-To: cvs-all@freebsd.org
Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1])
	by hub.freebsd.org (Postfix) with ESMTP
	id 72AFA37B400; Wed, 20 Feb 2002 06:54:21 -0800 (PST)
Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30])
	by duke.cs.duke.edu (8.9.3/8.9.3) with ESMTP id JAA16008;
	Wed, 20 Feb 2002 09:54:20 -0500 (EST)
Received: (from gallatin@localhost)
	by grasshopper.cs.duke.edu (8.11.6/8.9.1) id g1KEroq62146;
	Wed, 20 Feb 2002 09:53:50 -0500 (EST)
	(envelope-from gallatin@cs.duke.edu)
From: Andrew Gallatin <gallatin@cs.duke.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15475.47230.710214.568621@grasshopper.cs.duke.edu>
Date: Wed, 20 Feb 2002 09:53:50 -0500 (EST)
To: Max Khon <fjoe@FreeBSD.ORG>
Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/net if.c if_arc.h if_arp.h if_ethersubr.c if_fddisubr.c if_iso88025subr.c if_var.h if_vlan.c src/sys/netinet if_ether.c if_ether.h
In-Reply-To: <20020219151922.A31723@hub.freebsd.org>
References: <200202132138.g1DLcuB88159@freefall.freebsd.org>
	<20020219162648.A52559@grasshopper.cs.duke.edu>
	<20020219151922.A31723@hub.freebsd.org>
X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


Max Khon writes:
 > hi, there!
 > 
 > On Tue, Feb 19, 2002 at 04:26:48PM -0500, Andrew Gallatin wrote:
 > 
 > > > fjoe        2002/02/13 13:38:56 PST
 > > <...>
 > > >   Log:
 > > >   MFC: ARP support for variable length link level addresses
 > > 
 > > <...>
 > > >   1.18.2.13  +4 -0      src/sys/net/if_var.h
 > > 
 > > The addition of a pointer ( u_int8_t *if_broadcastaddr;) into struct
 > > ifnet breaks binary compatability in the 4-stable series for 3rd party
 > > network drivers by moving the ac_enaddr[] field down in struct arpcom.
 > 
 > [...]
 > 
 > does the attached patch look ok?
 > if yes is it ok to commit it to RELENG_4 only?

Looks OK & it appears to work just fine:

myri0: flags=843<UP,BROADCAST,RUNNING,SIMPLEX> mtu 9000
       inet 192.168.1.4 netmask 0xffffff00 broadcast 192.168.1.255
       ether 00:60:dd:7f:57:98 


Thanks very much!

Drew

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message