From owner-freebsd-bugs@FreeBSD.ORG  Thu Aug  7 17:00:04 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CE2BA106566C
	for <freebsd-bugs@hub.freebsd.org>;
	Thu,  7 Aug 2008 17:00:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id B15958FC15
	for <freebsd-bugs@hub.freebsd.org>;
	Thu,  7 Aug 2008 17:00:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m77H04am015532
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 7 Aug 2008 17:00:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m77H04tk015531;
	Thu, 7 Aug 2008 17:00:04 GMT (envelope-from gnats)
Date: Thu, 7 Aug 2008 17:00:04 GMT
Message-Id: <200808071700.m77H04tk015531@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Alex Kozlov <spam@rm-rf.kiev.ua>
Cc: 
Subject: Re: bin/126324: [patch] rc.d/tmp: Prevent mounting /tmp in second
	time
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Alex Kozlov <spam@rm-rf.kiev.ua>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Aug 2008 17:00:04 -0000

The following reply was made to PR bin/126324; it has been noted by GNATS.

From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: Kris Kennaway <kris@FreeBSD.org>, bug-followup@freebsd.org,
	spam@rm-rf.kiev.ua
Cc:  
Subject: Re: bin/126324: [patch] rc.d/tmp: Prevent mounting /tmp in second
	time
Date: Thu, 7 Aug 2008 19:57:53 +0300

 On Thu, Aug 07, 2008 at 12:35:43PM +0200, Kris Kennaway wrote:
 > Kris Kennaway wrote:
 > > Alex Kozlov wrote:
 > > 
 > >> Index: src/etc/rc.d/tmp
 > >> @@ -43,6 +43,7 @@
 > >>  #
 > >>  case "${tmpmfs}" in
 > >>  [Yy][Ee][Ss])
 > >> +    /sbin/umount /tmp 2>/dev/null && echo /tmp was already mounted!
 > >>      mount_md ${tmpsize} /tmp "${tmpmfs_flags}"
 > >>      chmod 01777 /tmp
 > >>      ;;
 > >> @@ -57,6 +58,7 @@
 > >>              echo "dropping into shell, ^D to continue anyway."
 > >>              /bin/sh
 > >>          else
 > >> +            /sbin/umount /tmp 2>/dev/null && echo /tmp was already 
 > >> mounted!
 > >>              mount_md ${tmpsize} /tmp "${tmpmfs_flags}"
 > >>              chmod 01777 /tmp
 > >>          fi
 > > 
 > > This will destroy any files the admin may have deliberately created on 
 > > /tmp after dropping to single user mode.
 > 
 > Er, coffee hadn't kicked in.  That will only happen with tmpfs which 
 > isn't used yet.  Still, a better solution might keep that in mind to 
 > avoid introducing a bug later.
 Well, as alternative We can just don't touch /tmp if it already mounted.
 This also prevent md device leak at least until bin/114468 will be
 resolved.
 
 
 --
 Adios