From owner-svn-src-head@freebsd.org Sat Apr 21 18:31:37 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1979FFB8D91 for ; Sat, 21 Apr 2018 18:31:37 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yw0-x231.google.com (mail-yw0-x231.google.com [IPv6:2607:f8b0:4002:c05::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B0D9772E39 for ; Sat, 21 Apr 2018 18:31:36 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yw0-x231.google.com with SMTP id i17-v6so3775720ywg.13 for ; Sat, 21 Apr 2018 11:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pj6sYxA9m7yqraLYRDjzuE31ChH+9piaowmKqemEjH8=; b=om5u/BXoMun5g5rKUboQUV0t97a95Dr1Z4XbFPjTwxAcxkpcZc78xjKeR8m7lkiHZ8 3L42wZu0k6WI8xay1ZfezdXXE3B7e7B+pKs0ipk/FYVLN1l8n22JS+P9z7zNLEgiJN5l 5cHXb/+gIfSL/QPm4B8oQPNZHH9V3m9RdFNUo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pj6sYxA9m7yqraLYRDjzuE31ChH+9piaowmKqemEjH8=; b=RCbj8L6TLXUi7dfCN50OZfiq1gzw9cLVj3sKyHLD77PFSSZYIHzJwWkP7XzxfKnLAn c1jJql0kFGSfangVz/RhUzDSs+bb3A1aPltiImlAsVbhKinEh2yWPa2rYN+CMZP3XrWO e68VYI266BHD16RkN7KkSrrpDA4/kbUHEDMuLXc8KsLmBX+qJTHnh9XdjEMNLC3T5J4I FXsTWmXnl7dZYBdGLe3JWJG0Eq7RW+//BRiTp+tB7RF2Zy4jUYS6UEPLeaXkGM2C++Ud +VqBtjSKoZfFi82yTQOFONNNhM5grTqWrxXJopPF4Sw1Kvflm/0zdN2v5gzZ4c8UYGpb RyTA== X-Gm-Message-State: ALQs6tAm/Z0FlRn4dVEu0dpAbbX8vwbSjRetpCGFb2kJcK7OIk0W1F4o cEoRmxgKECg3gLx8/vfY5PpSpai5cjzqBIyG7RUY6A== X-Google-Smtp-Source: AIpwx485PdRkOhJUaTE2HQlzERMBg4mNVcUIEzCK2vaEYj3kxWxMfbNsevcz4dV4P74xZqa4aFBx+T0MvIteCVxNLec= X-Received: by 2002:a0d:c446:: with SMTP id g67-v6mr8121098ywd.387.1524335495835; Sat, 21 Apr 2018 11:31:35 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:c709:0:0:0:0:0 with HTTP; Sat, 21 Apr 2018 11:31:05 -0700 (PDT) In-Reply-To: <201804211705.w3LH50Dk056339@repo.freebsd.org> References: <201804211705.w3LH50Dk056339@repo.freebsd.org> From: Eitan Adler Date: Sat, 21 Apr 2018 11:31:05 -0700 Message-ID: Subject: Re: svn commit: r332860 - head/sys/kern To: "Jonathan T. Looney" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Apr 2018 18:31:37 -0000 On 21 April 2018 at 10:05, Jonathan T. Looney wrote: > Author: jtl > Date: Sat Apr 21 17:05:00 2018 > New Revision: 332860 > URL: https://svnweb.freebsd.org/changeset/base/332860 > > Log: > When running with INVARIANTS, the kernel contains extra checks. However, > these assumptions may not hold true once we've panic'd. Therefore, the > checks hold less value after a panic. Additionally, if one of the checks > fails while we are already panic'd, this creates a double-panic which can > interfere with debugging the original panic. Rather than do this I'd rather we modify the invariants to more explicitly state under what conditions it holds. This might be something like KASSERT(!panic && ...) or KASSERT_NOT_IN_PANIC(...) or some other spelling. -- Eitan Adler